Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EXTERNAL deployment controller for ECS #8652

Merged
merged 2 commits into from Jun 23, 2020
Merged

Support EXTERNAL deployment controller for ECS #8652

merged 2 commits into from Jun 23, 2020

Conversation

kumarappan-arumugam
Copy link
Contributor

@kumarappan-arumugam kumarappan-arumugam commented May 15, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8133

Release note for CHANGELOG:

resource/aws_ecs_service: Add support for `EXTERNAL` deployment_controller

Changes:

  • resource/aws_ecs_service: Add support for EXTERNAL deployment_controller

Output from acceptance testing:

$ AWS_PROFILE=terraform-dev-test make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService_withDeploymentController_Type_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEcsService_withDeploymentController_Type_ -timeout 120m
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_External
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_External
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_External
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (191.92s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (268.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	269.551s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 15, 2019
@kumarappan-arumugam kumarappan-arumugam marked this pull request as ready for review May 17, 2019 01:54
@aeschright aeschright requested a review from a team June 28, 2019 18:16
@aeschright aeschright added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 12, 2019
@ludov04
Copy link

ludov04 commented Sep 26, 2019

Any update on this PR??

@ewbankkit
Copy link
Contributor

It looks like this is a duplicate of #8134.

@ludov04
Copy link

ludov04 commented Oct 23, 2019

Right, would be nice if one of them gets merged tho

@komlow
Copy link

komlow commented Jan 9, 2020

Anyone can merge this PR or #8134 ?
This feature was implemented on AWS about 10 months ago but we cannot use it yet with terraform.

@ludov04
Copy link

ludov04 commented Feb 19, 2020

@bflad Looks like this PR is got burried, and forgotten
Lots of people are waiting for this feature

@kumarappan-arumugam
Copy link
Contributor Author

Fixed merge conflict, can someone please merge this? PR is a year old.

@bflad bflad added this to the v2.68.0 milestone Jun 23, 2020
@bflad bflad self-assigned this Jun 23, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @kumarappan-arumugam 🚀 Pulling this in a 3-way merge with #8134 to give the earlier contributor credit and with very minor documentation/testing tweaks.

Output from acceptance testing:

--- PASS: TestAccAWSEcsService_basicImport (81.33s)
--- PASS: TestAccAWSEcsService_disappears (77.65s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (345.88s)
--- PASS: TestAccAWSEcsService_ManagedTags (80.69s)
--- PASS: TestAccAWSEcsService_PropagateTags (216.71s)
--- PASS: TestAccAWSEcsService_Tags (108.07s)
--- PASS: TestAccAWSEcsService_withAlb (289.93s)
--- PASS: TestAccAWSEcsService_withARN (92.20s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (195.70s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (48.74s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (60.43s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (298.78s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (49.28s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (77.40s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (76.81s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (90.55s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (91.38s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (91.77s)
--- PASS: TestAccAWSEcsService_withIamRole (142.00s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (114.04s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (167.26s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (166.53s)
--- PASS: TestAccAWSEcsService_withLbChanges (237.65s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (145.14s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (301.04s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (71.84s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (76.82s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (125.39s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (154.21s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (59.51s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (176.92s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (176.53s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (77.25s)

bflad added a commit that referenced this pull request Jun 23, 2020
@bflad bflad merged commit a6eaac6 into hashicorp:master Jun 23, 2020
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EXTERNAL to deployment_controller of ECS Service
6 participants