Support EXTERNAL deployment controller for ECS

[kumarappan-arumugam]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8133

Release note for CHANGELOG:

resource/aws_ecs_service: Add support for `EXTERNAL` deployment_controller

Changes:

• resource/aws_ecs_service: Add support for EXTERNAL deployment_controller

Output from acceptance testing:

$ AWS_PROFILE=terraform-dev-test make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService_withDeploymentController_Type_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEcsService_withDeploymentController_Type_ -timeout 120m
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_External
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_External
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_External
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (191.92s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (268.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	269.551s

[ludov04]

Any update on this PR??

[ewbankkit]

It looks like this is a duplicate of #8134.

[ludov04]

Right, would be nice if one of them gets merged tho

[komlow]

Anyone can merge this PR or #8134 ?
This feature was implemented on AWS about 10 months ago but we cannot use it yet with terraform.

[ludov04]

@bflad Looks like this PR is got burried, and forgotten
Lots of people are waiting for this feature

[kumarappan-arumugam]

Fixed merge conflict, can someone please merge this? PR is a year old.

[bflad]

Thank you so much, @kumarappan-arumugam 🚀 Pulling this in a 3-way merge with #8134 to give the earlier contributor credit and with very minor documentation/testing tweaks.

Output from acceptance testing:

--- PASS: TestAccAWSEcsService_basicImport (81.33s)
--- PASS: TestAccAWSEcsService_disappears (77.65s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (345.88s)
--- PASS: TestAccAWSEcsService_ManagedTags (80.69s)
--- PASS: TestAccAWSEcsService_PropagateTags (216.71s)
--- PASS: TestAccAWSEcsService_Tags (108.07s)
--- PASS: TestAccAWSEcsService_withAlb (289.93s)
--- PASS: TestAccAWSEcsService_withARN (92.20s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (195.70s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (48.74s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (60.43s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (298.78s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (49.28s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (77.40s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (76.81s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (90.55s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (91.38s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (91.77s)
--- PASS: TestAccAWSEcsService_withIamRole (142.00s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (114.04s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (167.26s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (166.53s)
--- PASS: TestAccAWSEcsService_withLbChanges (237.65s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (145.14s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (301.04s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (71.84s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (76.82s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (125.39s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (154.21s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (59.51s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (176.92s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (176.53s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (77.25s)

[ghost]

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!