Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ECR repository immutable image tags #9557

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9517

Release note for CHANGELOG:

esource/aws_ecr_repository: Support for image tag immutability

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEcrRepository_immutability'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEcrRepository_immutability -timeout 120m
=== RUN   TestAccAWSEcrRepository_immutability
=== PAUSE TestAccAWSEcrRepository_immutability
=== CONT  TestAccAWSEcrRepository_immutability
--- PASS: TestAccAWSEcrRepository_immutability (33.04s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       33.091s

@sunilkumarmohanty sunilkumarmohanty requested a review from a team July 30, 2019 20:34
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 30, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 30, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunilkumarmohanty 👋 Thanks for submitting this. Initial feedback below. Please let us know if you have any questions or do not have time to implement the items. 👍

aws/resource_aws_ecr_repository.go Show resolved Hide resolved
aws/resource_aws_ecr_repository_test.go Show resolved Hide resolved
website/docs/r/ecr_repository.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 30, 2019
@sunilkumarmohanty
Copy link
Contributor Author

Test Results

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEcrRepository_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEcrRepository_basic -timeout 120m
=== RUN   TestAccAWSEcrRepository_basic
=== PAUSE TestAccAWSEcrRepository_basic
=== CONT  TestAccAWSEcrRepository_basic
--- PASS: TestAccAWSEcrRepository_basic (32.17s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       32.213s


$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEcrRepository_immutability'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSEcrRepository_immutability -timeout 120m
=== RUN   TestAccAWSEcrRepository_immutability
=== PAUSE TestAccAWSEcrRepository_immutability
=== CONT  TestAccAWSEcrRepository_immutability
--- PASS: TestAccAWSEcrRepository_immutability (31.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       31.409s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Aug 2, 2019
@bflad bflad self-requested a review August 7, 2019 14:24
@bflad bflad added this to the v2.23.0 milestone Aug 7, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this contribution @sunilkumarmohanty 🚀

--- PASS: TestAccAWSEcrRepository_basic (8.95s)
--- PASS: TestAccAWSEcrRepository_immutability (9.07s)
--- PASS: TestAccAWSEcrRepository_tags (12.31s)

@bflad bflad merged commit ffded65 into hashicorp:master Aug 7, 2019
bflad added a commit that referenced this pull request Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR repository immutable image tags
2 participants