resource/ecs_cluster: Add ability to enable ECS Cluster Insights

[stack72]

Fixes: #9294

DataSource Tests:

acctests aws TestAccAWSEcsDataSource_
=== RUN   TestAccAWSEcsDataSource_ecsCluster
=== PAUSE TestAccAWSEcsDataSource_ecsCluster
=== RUN   TestAccAWSEcsDataSource_ecsClusterContainerInsights
=== PAUSE TestAccAWSEcsDataSource_ecsClusterContainerInsights
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
=== PAUSE TestAccAWSEcsDataSource_ecsContainerDefinition
=== RUN   TestAccAWSEcsDataSource_ecsTaskDefinition
=== PAUSE TestAccAWSEcsDataSource_ecsTaskDefinition
=== CONT  TestAccAWSEcsDataSource_ecsCluster
=== CONT  TestAccAWSEcsDataSource_ecsClusterContainerInsights
=== CONT  TestAccAWSEcsDataSource_ecsTaskDefinition
=== CONT  TestAccAWSEcsDataSource_ecsContainerDefinition
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (36.34s)
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (89.19s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (89.21s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (89.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	89.280s

Resource Tests:

acctests aws TestAccAWSEcsCluster_
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN   TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN   TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== RUN   TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== CONT  TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_Tags
=== CONT  TestAccAWSEcsCluster_disappears
=== CONT  TestAccAWSEcsCluster_containerInsights
--- PASS: TestAccAWSEcsCluster_disappears (19.46s)
--- PASS: TestAccAWSEcsCluster_containerInsights (28.05s)
--- PASS: TestAccAWSEcsCluster_basic (31.04s)
--- PASS: TestAccAWSEcsCluster_Tags (64.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.770s

[sandangel]

any chance this PR can get reviews?

[speedmann]

Adding a new cluster with containerInsights enabled seems to be working flawless.
Enabling it with an existing cluster causes terraform to display a change

Terraform will perform the following actions:

  # aws_ecs_cluster.existing will be updated in-place
  ~ resource "aws_ecs_cluster" "existing" {
        arn  = "arn:aws:ecs:us-east-2:xxx:cluster/test-cluster"
        id   = "arn:aws:ecs:us-east-2:xxx:cluster/test-cluster"
        name = "test-cluster"
        tags = {}

      - setting {
          - name  = "containerInsights" -> null
          - value = "disabled" -> null
        }
      + setting {
          + name  = "containerInsights"
          + value = "enabled"
        }
    }

And execution seems to be working, but container insights is not enabled. As far as i understand AWS documentation, containerinsight has to be enabled at creation time. It can't be changed later on.

[ewbankkit]

As of AWS SDK v1.23.13, ECS cluster settings can be updated, allowing Container Insights to be toggled.
Requires:

• Update module aws/aws-sdk-go to v1.23.13 #9938

[sandangel]

@ewbankkit that pr has been merged. yay !!!

[parabolic]

@stack72 FYI it is GA since around 2 days ago
https://aws.amazon.com/blogs/aws/operational-insights-for-containers-and-containerized-applications/ and can be enabled on existing clusters.

Let me know if you need any help with testing or anything else since we need this feature enabled.

Many thanks for the pr!

[stack72]

ok I have updated the PR to now allow containerInsights to be enabled for an existing cluster as per the work #9938 allows

[bflad]

After some minor adjustments on merge, looks good. Thanks so much, @stack72 🚀

--- PASS: TestAccAWSEcsCluster_disappears (9.90s)
--- PASS: TestAccAWSEcsCluster_basic (13.35s)
--- PASS: TestAccAWSEcsCluster_containerInsights (25.56s)
--- PASS: TestAccAWSEcsCluster_Tags (27.62s)

--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (14.16s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (14.25s)

[bflad]

Nit: To prevent potential panics (unlikely in this case, but a general pattern for consistency), we should use the AWS Go SDK conversion functions (e.g. aws.StringValue())

Suggested change

	"name": *setting.Name,
	"name": aws.StringValue(setting.Name),

[bflad]

Nit: Prefer the wording of "configuration block" over "parameter" (which incorrectly may signal it can work as an argument with setting = ...)

Suggested change

	* `setting` - (Optional) The setting to use when creating a cluster. This parameter is used to enable CloudWatch Container Insights for a cluster. Defined below.
	* `setting` - (Optional) Configuration block(s) with cluster settings. For example, this can be used to enable CloudWatch Container Insights for a cluster. Defined below.

[bflad]

Nit: Since the aws_ecs_task_definition and aws_ecs_service resources are not necessary for testing the aws_ecs_cluster data source, we can omit them.

[ghost]

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!