Add pagination support (introduced in aws-sdk-go v1.33.21) and multiple baselines per patch group.

[melbit-michaelw]

This PR modifies the Id for an SSM Patch Group to be the Patch Group Name joined to the BaselineId by a ":". This allows an SSM Patch Group to support multiple baselines.

Please note that pre-existing patch groups will be recreated due to the change in Id (this happens without issue in my testing as the AWS API call succeeds even if the patch group already has that baseline applied).

Secondly, this PR adds pagination support (added in aws-sdk-go v1.33.21) to the aws_ssm_patch_group resource.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9603
Closes #13580

As it involved modifying the same code, I have merged the work from my previous PR ( #13752 ) into this one. Please let me know if that's a problem..

Release note for CHANGELOG:

resource/aws_ssm_patch_group: Support multiple baselines (one per OS) on an SSM patch group (#9603)
resource/aws_ssm_patch_group: Support pagination for patch groups (#13580)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMPatchGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMPatchGroup -timeout 120m
=== RUN   TestAccAWSSSMPatchGroup_basic
=== PAUSE TestAccAWSSSMPatchGroup_basic
=== CONT  TestAccAWSSSMPatchGroup_basic
--- PASS: TestAccAWSSSMPatchGroup_basic (28.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       29.634s

[melbit-michaelw]

Is there anything I can do to get this PR looked at ?

[melbit-michaelw]

@YakDriver , @gdavison - Apologies for reaching out to you both directly, but this PR has been pending review for quite some time now.

It is functionality that my company urgently needs.

Is there anything further I need to do (or can do) in order to get it reviewed ?

Thank you for your time.

[fatalglitch]

This seems like it has been pending for a very long time, with no issues identified. When can this get merged?

[melbit-michaelw]

@apparentlymart , @YakDriver , @gdavison , @anGie44 - Apologies for mentioning you all directly, but I don't know what else I can do to get this PR reviewed..

It's been waiting for over 2 months now with absolutely no feedback.

Is there anything further I need to do (or can do) in order to get it reviewed and progressing ?

Thank you for your time.

[breathingdust]

👋 Hi @melbit-michaelw thanks for the contribution! Apologies for the radio silence, the engineers get so many direct and indirect (via team) pings its just not feasible to answer every one. Right now the team are working through items in order of priority, primarily determined by upvotes on the PR or linked issue. I can see that this issue/pr has significant support, so it is is in our backlog but at this time we can't give an ETA for when it will be reviewed.

We appreciate your patience and thanks again for the contribution!

[eric51893]

Hello, been a while, any more clarity on the status of this request?

[anGie44]

Hi @melbit-michaelw, thank you for this PR! Overall the resource ID change and pagination support are great solutions to the associated bug. Just a couple quick notes that I'll be pushing up changes to address so we can get this into the upcoming release.

1. As you mentioned, we'll need a state migration to ensure backwards compatability, so I've added functionality and a test.
2. The AWS docs list : as a valid character for both resource arguments, so later when we parse the ID based on the delimiter it could become troublesome, so instead I've replaced the delimiter with a ,.
3. Since the pagination function is used across the resource and test file, I've moved it to the ssm internal service package for a more DRY implementation.
4. When iterating through the PatchGroupsPages, I've preemptively parsed the ID if in the future we support importing this resource.
5. I've added test coverage for the 1:many relationship

[anGie44]

Output of acceptance tests (commercial):

--- PASS: TestAccAWSSSMPatchGroup_basic (14.19s)
--- PASS: TestAccAWSSSMPatchGroup_disappears (15.23s)
--- PASS: TestAccAWSSSMPatchGroup_multipleBaselines (15.80s)

--- PASS: TestResourceAWSSSMPatchGroupStateUpgradeV0 (0.00s)

[anGie44]

Thank you again @melbit-michaelw !🚀

[ghost]

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!