Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding for new Route53 Resolver service #6554

Closed
wants to merge 2 commits into from

Conversation

ewbankkit
Copy link
Contributor

Fixes #6525.
Minimal changes to enable new Route53 Resolver resources.
Includes aws-sdk-go additions from #6549.

Usage:

conn := meta.(*AWSClient).r53resolverconn
...
// In resource read:
if err := getTagsRoute53Resolver(conn, d, arn); err != nil {
    return err
}
...
// In resource update:
if err := setTagsRoute53Resolver(conn, d, arn); err != nil {
    return err
}

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 22, 2018
Add temporary '// nolint' comments.
@ewbankkit
Copy link
Contributor Author

Temporarily added // nolint comments to prevent errors:

$ make lint
==> Checking source code against linters...
aws/tagsRoute53Resolver.go:14:6:warning: func getTagsRoute53Resolver is unused (U1000) (unused)
aws/tagsRoute53Resolver.go:14:1:warning: getTagsRoute53Resolver is unused (deadcode)
aws/tagsRoute53Resolver.go:44:6:warning: func setTagsRoute53Resolver is unused (U1000) (unused)
aws/tagsRoute53Resolver.go:44:1:warning: setTagsRoute53Resolver is unused (deadcode)
GNUmakefile:34: recipe for target 'lint' failed
make: *** [lint] Error 1

These should be removed once we have code using these functions,

@ewbankkit
Copy link
Contributor Author

I'm going to close this one as the relevant commit is included in #6571 and #6574.

@ewbankkit ewbankkit closed this Nov 28, 2018
@ewbankkit ewbankkit deleted the issue-6525 branch November 28, 2018 13:59
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support route53resolver
2 participants