Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_neptunce_cluster_instance: Add missing third availability zone from cluster configuration #8322

Merged
merged 1 commit into from
Apr 26, 2019
Merged

tests/resource/aws_neptunce_cluster_instance: Add missing third availability zone from cluster configuration #8322

merged 1 commit into from
Apr 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 16, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Similar to RDS, Neptune requires clusters to have three availability zones if manually configured.

Previous output from acceptance testing:

--- FAIL: TestAccAWSNeptuneClusterInstance_withaz (865.51s)
    testing.go:538: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        DESTROY/CREATE: aws_neptune_cluster.default
...
          availability_zones.#:                 "3" => "2" (forces new resource)
          availability_zones.2050015877:        "us-west-2c" => "" (forces new resource)
          availability_zones.221770259:         "us-west-2b" => "us-west-2b"
          availability_zones.2487133097:        "us-west-2a" => "us-west-2a"
...

Output from acceptance testing:

--- PASS: TestAccAWSNeptuneClusterInstance_withaz (801.98s)

@bflad
tests/resource/aws_neptunce_cluster_instance: Add missing third avail…
3d73974 
…ability zone from cluster configuration

Similar to RDS, Neptune requires clusters to have three availability zones if manually configured.

Previous output from acceptance testing:

```
--- FAIL: TestAccAWSNeptuneClusterInstance_withaz (865.51s)
    testing.go:538: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        DESTROY/CREATE: aws_neptune_cluster.default
...
          availability_zones.#:                 "3" => "2" (forces new resource)
          availability_zones.2050015877:        "us-west-2c" => "" (forces new resource)
          availability_zones.221770259:         "us-west-2b" => "us-west-2b"
          availability_zones.2487133097:        "us-west-2a" => "us-west-2a"
...
```

Output from acceptance testing:

```
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (801.98s)
```
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. labels Apr 16, 2019
@bflad bflad requested a review from a team April 16, 2019 02:32
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 16, 2019
nywilken
nywilken approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit d403298 into master Apr 26, 2019
@nywilken nywilken deleted the t-aws_neptune_cluster_instance-third-az branch April 26, 2019 15:16
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken