Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_user support for immutable_id property #207

Merged
merged 5 commits into from
Mar 10, 2020

Conversation

derek-burdick
Copy link
Contributor

Implements #206

@ghost ghost added the size/XS label Jan 17, 2020
@katbyte katbyte added this to the v0.8.0 milestone Jan 26, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @derek-burdick, in addition to the comments i've left inline could we update the documentation with the new property?

azuread/data_user.go Outdated Show resolved Hide resolved
azuread/resource_user.go Show resolved Hide resolved
@ghost ghost added size/M and removed size/S labels Mar 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @derek-burdick, thanks for the pr! i hope you don't mind but iv'd pushed some changes to your branch so i could merge it for 0.8 🙂 LGTM now!

@katbyte katbyte merged commit 9f78aa1 into hashicorp:master Mar 10, 2020
katbyte added a commit that referenced this pull request Mar 10, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
@ghost
Copy link

ghost commented May 14, 2020

This has been released in version 0.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.8.0"
}
# ... other configuration ...

@ghost ghost unlocked this conversation May 14, 2020
@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants