Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_group - owners is now additive on creation allowing existing owner to be in owners list #211

Merged
merged 1 commit into from
Mar 11, 2020
Merged

azuread_group - owners is now additive on creation allowing existing owner to be in owners list #211

merged 1 commit into from
Mar 11, 2020

Conversation

jnehlt
Copy link
Contributor

@jnehlt jnehlt commented Jan 28, 2020

Fixed func resourceGroupCreate. From now you can pass your object_id to the owner list

(fixes #212)

@ghost ghost added the size/XS label Jan 28, 2020
@jnehlt jnehlt mentioned this pull request Jan 28, 2020
@jnehlt
Copy link
Contributor Author

jnehlt commented Jan 28, 2020

Please take a look to this issue: IssueURL

@jnehlt jnehlt changed the title Owner list issue ADGroup Owner list issue Jan 28, 2020
@katbyte katbyte added this to the v0.8.0 milestone Mar 11, 2020
@katbyte katbyte changed the title ADGroup Owner list issue azuread_group - owners is now additive on creation allowing existing owner to be in owners list Mar 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jnehlt! LGTM 👍

@katbyte katbyte merged commit 842e9b1 into hashicorp:master Mar 11, 2020
katbyte added a commit that referenced this pull request Mar 11, 2020
@jnehlt jnehlt deleted the bugfix/azuread_group/creation branch March 18, 2020 08:12
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
@ghost
Copy link

ghost commented May 14, 2020

This has been released in version 0.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.8.0"
}
# ... other configuration ...

@ghost ghost unlocked this conversation May 14, 2020
@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_group creation
2 participants