Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_group - support for the description property #216

Merged
merged 5 commits into from
Mar 11, 2020

Conversation

quintok
Copy link
Contributor

@quintok quintok commented Feb 18, 2020

This is my first attempt at modifying code using this sdk and maybe I'm missing something but the sdk doesn't seem to expose the patch group call? Am I just blind? With this missing I've made groups recreate on modification on description but that's really kinda lame as an end user.

fixes #210

@katbyte katbyte added this to the v0.8.0 milestone Mar 11, 2020
@ghost ghost added size/M and removed size/S labels Mar 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @quintok!

I hope you don't mind but i've pushed some changes so i could mege this in for 0.8. Unfortunately the property will have to remain force new asi don't believe there is any group update method in the SDK at this time 😞

LGTM now 👍

@katbyte katbyte changed the title Add description as an exposed property to the Group resource azuread_group - support for the description property Mar 11, 2020
@katbyte katbyte merged commit 73c1b3f into hashicorp:master Mar 11, 2020
katbyte added a commit that referenced this pull request Mar 11, 2020
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
@ghost
Copy link

ghost commented May 14, 2020

This has been released in version 0.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.8.0"
}
# ... other configuration ...

@ghost ghost unlocked this conversation May 14, 2020
@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_group Description
2 participants