azuread_group: remediate replication delays when adding/removing group members

[manicminer]

1. Attempt up to 10 times to add a group member with fixed 2 second backoff
2. Ensure 10 affirmative responses when retrieving group members after adding
3. Attempt up to 10 times to remove a group member with fixed 2 second backoff
4. Ensure 10 affirmative responses when retrieving group members after removing

Fixes:

Error adding group member "62a54f8c-eef7-4106-9989-aa9018f46a98" to Azure AD Group with ID "d8c4d6c5-7d04-4865-85a6-cf311f1a619c": graphrbac.GroupsClient#AddMember: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="Unknown" Message="Unknown service error" Details=[{"odata.error":{"code":"Request_BadRequest","date":"2020-06-17T02:03:42","message":{"lang":"en","value":"One or more added object references already exist for the following modified properties: 'members'."},"requestId":"aaa440fc-7671-4d5d-b353-f599f1335ae5"}}]

Error Deleting group member "ecd616ca-06e3-4c36-9932-ecfeef38ffe6" from Azure AD Group with ID "c7196f3e-5d41-4726-8293-873712dd9830": graphrbac.GroupsClient#RemoveMember: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="Unknown" Message="Unknown service error" Details=[{"odata.error":{"code":"Request_BadRequest","date":"2020-06-17T23:17:44","message":{"lang":"en","value":"One or more removed object references do not exist for the following modified properties: 'members'."},"requestId":"c690ded0-7a1f-4079-9717-c857d3513e23"}}]

[manicminer]

Tests now passing:

[katbyte]

Awesome! LGTM 👍

[ghost]

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!