Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for guest users #401

Merged
merged 6 commits into from
Feb 23, 2021
Merged

added support for guest users #401

merged 6 commits into from
Feb 23, 2021

Conversation

lde
Copy link
Contributor

@lde lde commented Feb 15, 2021

Allow creation of guests users in azure active directory.

Refers issues #307 and #41

katbyte
katbyte requested changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lde - thanks for the PR. one question i've left inline about default/computed and other then that we need to update the docs too

internal/services/users/user_resource.go Outdated Show resolved Hide resolved
@lde
Copy link
Contributor Author

lde commented Feb 17, 2021

Hi,
I've already updated the documentation by adding the property in user.md. Do yo see more to to ?

I've replied to your inline comment.

Thanks

@lde lde requested a review from katbyte February 19, 2021 10:25
manicminer
manicminer requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @lde, I have some other minor comments mostly just formatting related. This tests well and if we can adjust the schema per @katbyte's suggestion and the comments below, this should be good to merge!

internal/services/users/user_resource.go Show resolved Hide resolved
internal/services/users/user_resource_test.go Outdated Show resolved Hide resolved
internal/validate/strings.go Show resolved Hide resolved
internal/validate/strings.go Outdated Show resolved Hide resolved
internal/services/users/user_resource.go Outdated Show resolved Hide resolved
docs/resources/user.md Outdated Show resolved Hide resolved
lde and others added 4 commits February 23, 2021 10:03
@lde @manicminer
Update internal/services/users/user_resource.go
a65ffa9 
Co-authored-by: Tom Bamford <tom@bamford.io>
@lde @manicminer
Update internal/validate/strings.go
a9fdb7d 
Co-authored-by: Tom Bamford <tom@bamford.io>
@lde @manicminer
Update docs/resources/user.md
029a329 
Co-authored-by: Tom Bamford <tom@bamford.io>
@lde
refactor
9c9b600
@lde lde requested a review from manicminer February 23, 2021 09:43
@manicminer
Copy link
Member

Fixes #41
Fixes #307

This was linked to issues Feb 23, 2021
azuread_group: Support for AzureAD B2B user invitations (guests) #41
Closed
Support guest user invitations #307
Closed
@manicminer
Copy link
Member

Test results

Screenshot 2021-02-23 at 11 59 59

@manicminer manicminer merged commit 0a1f623 into hashicorp:main Feb 23, 2021
manicminer added a commit that referenced this pull request Feb 23, 2021
@manicminer
Update changelog for #401
168642d
@manicminer manicminer added this to the v1.5.0 milestone Feb 23, 2021
@manicminer manicminer mentioned this pull request Feb 23, 2021
Closed
@lde lde deleted the guest_users branch March 2, 2021 09:10
@romainDavaze romainDavaze mentioned this pull request Mar 8, 2021
Closed
@manicminer manicminer mentioned this pull request Mar 8, 2021
Merged
@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
@ghost
Copy link

ghost commented May 20, 2021

This has been released in version 1.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.5.0"
}
# ... other configuration ...

@ghost ghost unlocked this conversation May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
enhancement feature/users
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

Support guest user invitations azuread_group: Support for AzureAD B2B user invitations (guests)
3 participants
@lde @manicminer @katbyte