Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: correctly read reply URL's from SDK #21

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 22, 2019

fixes #6

@katbyte katbyte added this to the 0.2.0 milestone Jan 22, 2019
@katbyte katbyte requested a review from a team January 22, 2019 00:59
@ghost ghost added the size/M label Jan 22, 2019
@katbyte
Copy link
Collaborator Author

katbyte commented Jan 22, 2019

[16:56:22] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azuread▸app/fix-reply_urls$ make fmt; make testacc TEST=./azuread TESTARGS=-test.run=TestAccAzureADApplication
==> Fixing source code with gofmt...
gofmt -s -w ./azuread
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azuread -v -test.run=TestAccAzureADApplication -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azuread/version.ProviderVersion=acc"
=== RUN   TestAccAzureADApplicationDataSource_byObjectId
=== PAUSE TestAccAzureADApplicationDataSource_byObjectId
=== RUN   TestAccAzureADApplicationDataSource_byObjectIdComplete
=== PAUSE TestAccAzureADApplicationDataSource_byObjectIdComplete
=== RUN   TestAccAzureADApplicationDataSource_byName
=== PAUSE TestAccAzureADApplicationDataSource_byName
=== RUN   TestAccAzureADApplication_basic
=== PAUSE TestAccAzureADApplication_basic
=== RUN   TestAccAzureADApplication_availableToOtherTenants
=== PAUSE TestAccAzureADApplication_availableToOtherTenants
=== RUN   TestAccAzureADApplication_complete
=== PAUSE TestAccAzureADApplication_complete
=== RUN   TestAccAzureADApplication_update
=== PAUSE TestAccAzureADApplication_update
=== CONT  TestAccAzureADApplicationDataSource_byObjectId
=== CONT  TestAccAzureADApplication_availableToOtherTenants
=== CONT  TestAccAzureADApplication_update
=== CONT  TestAccAzureADApplication_complete
=== CONT  TestAccAzureADApplicationDataSource_byName
=== CONT  TestAccAzureADApplication_basic
=== CONT  TestAccAzureADApplicationDataSource_byObjectIdComplete
--- PASS: TestAccAzureADApplication_basic (4.42s)
--- PASS: TestAccAzureADApplication_availableToOtherTenants (4.69s)
--- PASS: TestAccAzureADApplication_complete (5.15s)
--- PASS: TestAccAzureADApplicationDataSource_byObjectId (5.48s)
--- PASS: TestAccAzureADApplication_update (5.82s)
--- PASS: TestAccAzureADApplicationDataSource_byObjectIdComplete (5.84s)
--- PASS: TestAccAzureADApplicationDataSource_byName (6.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azuread/azuread	6.480s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit b29c5aa into master Jan 22, 2019
@katbyte katbyte deleted the app/fix-reply_urls branch January 22, 2019 11:00
katbyte added a commit that referenced this pull request Jan 22, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureAD Application URL's being modified
2 participants