r/application_gateway: ensuring the casing on identity_ids within the identity block

[JohnDelisle]

Fixes issue with identity_ids being case-sensitive, which results in terraform forcing an update on each apply due to case differences in e.g. .../resourceGroups/... vs. .../resourcegroups/.... See issue #10029

Tested by building azurerm provider 2.4.0 locally.

[favoretti]

Convert it to generator instead maybe?

[katbyte]

I'm going to second what @favoretti said, instead of making this property case insensitive we should use the new Parse functions when reading them in from azure to store them in the correct case.

[JohnDelisle]

I'm going to second what @favoretti said, instead of making this property case insensitive we should use the new Parse functions when reading them in from azure to store them in the correct case.

Thanks for the feedback!

Is there an App Gw property that's currently implemented this way? I'm new to this and could use an example/ template of how it's done.

Also, does this approach still achieve the objective of accepting a case-insensitive value for identity_ids? What I'm getting at is that identity_ids could be getting pulled programatically (e.g. as a data source or as a resource elsewhere in the module, where the case would likely be "as expected"), or they could be added by humans who expect them to be case-insensitive.

[katbyte]

@JohnDelisle - it will treat parts of the resource id as case insensitive (the non user specified bits like resourceGroup), you can see how to generate the parse functions in the resourceid.go files in many of the services now (not sure if they exist for ap gateware, i'm on mobile right now)

[JohnDelisle]

@katbyte I've followed @sharebear's lead in #10105 and used azurerm/internal/services/msi/parse. Tested working with /ResourceGroup/ and /resourceGroup/.

[tombuildsstuff]

LGTM - thanks for this @JohnDelisle

dismissing since changes have been pushed

[tombuildsstuff]

Tests look good 👍

[ghost]

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!