Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log_analytics_workspace data source return parsed ID #10162

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Make log_analytics_workspace data source return parsed ID #10162

merged 1 commit into from
Jan 13, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jan 13, 2021

LAW data source didn't make use of generated parser, therefore returning IDs lowercased. This addresses the problem.

Fixes #10116

@ghost ghost added the size/XS label Jan 13, 2021
@favoretti favoretti changed the title Make data source return parsed ID Make log_analytics_workspace data source return parsed ID Jan 13, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - this LGTM 👍

@katbyte katbyte added this to the v2.43.0 milestone Jan 13, 2021
@tombuildsstuff tombuildsstuff merged commit f833f41 into hashicorp:master Jan 13, 2021
tombuildsstuff added a commit that referenced this pull request Jan 13, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_log_analytics_workspace data source outputting all lowercase id
3 participants