Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKU parameter for azurerm_firewall_policy #10186

Merged
merged 8 commits into from
Jan 23, 2021

Conversation

AliAllomani
Copy link
Contributor

Fixes #9886

$ make testacc TEST='./azurerm/internal/services/firewall' TESTARGS='-run=TestAccFirewallPolicy_basicPremium' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/firewall -v -run=TestAccFirewallPolicy_basicPremium -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccFirewallPolicy_basicPremium
=== PAUSE TestAccFirewallPolicy_basicPremium
=== CONT  TestAccFirewallPolicy_basicPremium
--- PASS: TestAccFirewallPolicy_basicPremium (116.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/firewall  118.610s

$ make testacc TEST='./azurerm/internal/services/firewall' TESTARGS='-run=TestAccFirewallPolicy_update' TESTTIMEOUT='60m'==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/firewall -v -run=TestAccFirewallPolicy_update -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccFirewallPolicy_update
=== PAUSE TestAccFirewallPolicy_update
=== CONT  TestAccFirewallPolicy_update
--- PASS: TestAccFirewallPolicy_update (219.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/firewall  222.069s

@ghost ghost added documentation size/S and removed size/XXL labels Jan 22, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @caius - this looks good aside from that we shouldn't be ignoring case, for the SKU unless there is a reason to - i'm going to flip that and then run the tests.

Other then that LGTM 👍

@katbyte katbyte added this to the v2.45.0 milestone Jan 22, 2021
@katbyte katbyte merged commit 32e61e2 into hashicorp:master Jan 23, 2021
katbyte added a commit that referenced this pull request Jan 23, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 23, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SKU argument for azurerm_firewall_policy
2 participants