Adding new application_gateway data_source

[petems]

Closes #5030

Draft for now, as I want to make sure I'm making the data_source correctly, after that I'll add the rest of the attributes

[tombuildsstuff]

hey @petems

Thanks for opening this PR.

I've taken a look through and this is off to a good start - I've taken a look through and left some comments inline, as mentioned offline this'll need to be registered here to be usable in the provider: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/network/registration.go#L24

Thanks!

[petems]

I've pulled most of the logic from the resource, so there's a lot of duplicted code here, is there value in refactoring this into a shared librariy? If so, is there an example out there?

[katbyte]

@petems - we're going to need to flip all the properties to computed as this is a data source

[petems]

@katbyte done, everything's set as computed except name and Resource Group

[tombuildsstuff]

hey @petems

Thanks for pushing those changes - I've taken a look through and left some comments inline, if we can get those sorted (and subsequently add/generate some documentation, there's details on how to generate that in the readme) - then we should be able to run the tests here 👍

Thanks!

[tombuildsstuff]

whilst this'd work for a Resource (since we have an ID) - it won't work for a Data Source, so this'd want to be:

Suggested change

	name := id.Path["applicationGateways"]
	name := d.Get("name").(string)
	resourceGroup := d.Get("resource_group_name").(string)

[tombuildsstuff]

since this is a Data Source rather than a Resource, we should raise an error here when this doesn't exist:

Suggested change

	return nil
	return fmt.Errorf("Application Gateway %q was not found in Resource Group %q", name, resGroup)

[tombuildsstuff]

this data source only defines name, location, resource_group_name, tags above, these other fields don't exist (so will raise an error) - can we remove them, or add the additional fields to the schema?

[tombuildsstuff]

sorry, my bad - the type name for this is

Suggested change

	`, AppGatewayResource{}.basic(data))
	`, ApplicationGatewayResource{}.basic(data))

dismissing since I've pushed changes

[tombuildsstuff]

Tests look good 👍

[ghost]

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!