Support application gateway backend pool configuration

[abn]

Support application gateway pool configuration for both vmss and network interface.

This change-set preserves code changes implemented by @agolomoodysaada in PR #884. A few changes were made to the original commit to get vmss working and verified as expected.

In addition to vmss, this also adds support for application gateway backend pool configuration for network interface resources and data sources.

Supersedes: #884
Closes #857

[tombuildsstuff]

hey @abn

Thanks for this PR / fixing the outstanding issue from #884 - I've noticed one minor thing that needs to be fixed up but this otherwise LGTM :)

Thanks!

[tombuildsstuff]

can we move this assignment out of the if statement and make this:

addressPools := make([]interface{}, 0)
if properties.ApplicationGatewayBackendAddressPools != nil {
  # ...
}
config["application_gateway_backend_address_pool_ids"] = schema.NewSet(schema.HashString, addressPools)

this will ensure the application_gateway_backend_address_pool_ids variable is set to an empty list if the field is nil (which will mean any changes are detected)

[abn]

Ack. Done.

[abn]

@tombuildsstuff thanks for the review; changed as requested. Let me know if you notice anything else.

[tombuildsstuff]

hey @abn

Thanks for pushing those changes - this now LGTM - I've kicked off the test suite and we should get the results shortly :)

Thanks!

[tombuildsstuff]

Ignoring the known issue with the Application Gateway API - the tests pass:

Thanks for this!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!