Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource - azurerm_data_factory_linked_service_azure_table_storage #10305

Conversation

jbinko
Copy link
Contributor

@jbinko jbinko commented Jan 25, 2021

This is the implementation of new resource based on demand from: #6174
Please review and let me know if you can merge to TF provider.

Generally copy/paste from exisitng azurerm_data_factory_linked_service_azure_blob_storage and also fixing some items in azurerm_data_factory_linked_service_azure_blob_storage

make acctests SERVICE='datafactory' TESTARGS='-run=TestAccDataFactoryLinkedServiceAzureTableStorage_basic' TESTTIMEOUT='180m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/datafactory/tests/ -run=TestAccDataFactoryLinkedServiceAzureTableStorage_basic -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccDataFactoryLinkedServiceAzureTableStorage_basic
=== PAUSE TestAccDataFactoryLinkedServiceAzureTableStorage_basic
=== CONT TestAccDataFactoryLinkedServiceAzureTableStorage_basic
--- PASS: TestAccDataFactoryLinkedServiceAzureTableStorage_basic (121.31s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory/tests 121.385s

make acctests SERVICE='datafactory' TESTARGS='-run=TestAccDataFactoryLinkedServiceAzureTableStorage_update' TESTTIMEOUT='180m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/datafactory/tests/ -run=TestAccDataFactoryLinkedServiceAzureTableStorage_update -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccDataFactoryLinkedServiceAzureTableStorage_update
=== PAUSE TestAccDataFactoryLinkedServiceAzureTableStorage_update
=== CONT TestAccDataFactoryLinkedServiceAzureTableStorage_update
--- PASS: TestAccDataFactoryLinkedServiceAzureTableStorage_update (164.23s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory/tests 164.305s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbinko - this LGTM

@katbyte katbyte added this to the v2.45.0 milestone Jan 28, 2021
@katbyte katbyte merged commit 84530e3 into hashicorp:master Jan 28, 2021
katbyte added a commit that referenced this pull request Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@jbinko jbinko deleted the newResource/azurerm_data_factory_linked_service_azure_table_storage branch January 29, 2021 13:14
@speaktosteve
Copy link

speaktosteve commented Feb 17, 2021

This is great, thanks @jbinko. I seem to be missing a key concept though, I dont see a resource for table storage datasets that can use this linked service. So, how do I leverage this linked service to pull data from table storage?

image

@jbinko
Copy link
Contributor Author

jbinko commented Feb 19, 2021

OK got it. So you are looking also for azurerm_data_factory_dataset_azure_table. Not only for azurerm_data_factory_linked_service_azure_table_storage. I understood original request was for linked service only. Let me explore and I'll create new request for azurerm_data_factory_dataset_azure_table and link it to relevant issues.

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants