Support for Secure Webhook Receiver in azurerm_monitor_action_group

[yupwei68]

Fix #10510

Manually tests pass.

It requires configuring your AAD application to expose a protected API to be called by a daemon app, and enabling Action Groups to use your Azure AD Application (which include New-AzureADServiceAppRoleAssignment in MS Graph), which could not be integrated into acctest e2e testing currently.

[katbyte]

Thanks @yupwei68 - left a comment about the schema inline

[yupwei68]

Thanks @katbyte for comments. Changes have been pushed. Please continue reviewing.

[yupwei68]

@katbyte I've added the acctest. Please continue reviewing.
=== RUN TestAccMonitorActionGroup_secureWebhookReceiver
=== PAUSE TestAccMonitorActionGroup_secureWebhookReceiver
=== CONT TestAccMonitorActionGroup_secureWebhookReceiver
--- PASS: TestAccMonitorActionGroup_secureWebhookReceiver (287.65s)

[tombuildsstuff]

hey @yupwei68

Thanks for pushing those changes - I've taken a look through and left some comments inline but if we can fix those up then this should otherwise be good to go 👍

Thanks!

[yupwei68]

Thanks Tom for your comments. Changes have been updated. Please continue reviewing.

[yupwei68]

=== RUN TestAccMonitorActionGroup_secureWebhookReceiver
=== PAUSE TestAccMonitorActionGroup_secureWebhookReceiver
=== CONT TestAccMonitorActionGroup_secureWebhookReceiver
--- PASS: TestAccMonitorActionGroup_secureWebhookReceiver (281.84s)

Test has passed.

[katbyte]

Thanks @yupwei68 - LGTM 👍

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[alastairtree]

FYI I looks like something in this change may have broken data.azurerm_monitor_action_group as suddenly our deploys have broken once they upgraded to using 2.50. The error looks like below. Will do some investigation and will create an issue if required.

Error setting `webhook_receiver`: Invalid address to set: []string{"webhook_receiver", "0", "aad_auth"} 

[yupwei68]

@alastairtree Unfortunately, I could not reproduce your error. I've created a webhook at version 2.49.0, and then update this at 2.50.0. They are applied successfully. Would you create an issue for this, with the details of reproducing steps and you've created the azurerm_monitor_action_group based on which version?

[alastairtree]

It is the data source that's broken not the resource. See #10854

[marioanton]

Same here, this is breaking the retrieval/refresh of action groups with webhooks not configured as securewebhooks.

[manicminer]

There's a fix for this incoming in #10876

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!