r/azurerm_eventgrid_event_subscription - advanced_filter MaxItems increase from 5 to 25

[jbinko]

Fix for #10620

• Limit increased to 25 values per filter item.
• Documentation was updated
• I added acc tests to verify implementation

It would be nice to implement validation function to verify that total number of values inside advanced_filter block <= 25.
As a maximum of total number of advanced filter values allowed on event subscription is 25.
Any guidance on optimal approach (where to inject validation function for advanced_filter block) is welcomed.

make testacc TEST=./azurerm/internal/services/eventgrid TESTARGS='-run=TestAccEventGridEventSubscription_advancedFilterMaxItems'make testacc TEST=./azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource_test.go TESTARGS='-run=TestAccEventGridEventSubscription_advancedFilterMaxItems'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource_test.go -v -run=TestAccEventGridEventSubscription_advancedFilterMaxItems -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccEventGridEventSubscription_advancedFilterMaxItems
=== PAUSE TestAccEventGridEventSubscription_advancedFilterMaxItems
=== CONT TestAccEventGridEventSubscription_advancedFilterMaxItems
--- PASS: TestAccEventGridEventSubscription_advancedFilterMaxItems (159.80s)
PASS
ok command-line-arguments 159.874s

make testacc TEST=./azurerm/internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go TESTARGS='-run=TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource_test.go -v -run=TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
=== PAUSE TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
=== CONT TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems
--- PASS: TestAccEventGridSystemTopicEventSubscription_advancedFilterMaxItems (178.36s)
PASS
ok command-line-arguments 178.438s

[katbyte]

Thanks @jbinko - LGTM 👍

[ghost]

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!