New Resource: azurerm_redis_enterprise_cluster & azurerm_redis_enterprise_database
#10706
Conversation
There was a problem hiding this comment.
Thanks for the PR @WodansSon - in addition to the comments iv'e left inline is there a reason we are not using the generated parse functions?
| "1", | ||
| "2", | ||
| "3", | ||
| }, true), |
There was a problem hiding this comment.
can we make this case sensitive? shouldn't matter as its numbers :P
| if v, ok := d.GetOk("zones"); ok { | ||
| // Zones are currently not supported in these regions | ||
| if location == "centraluseuap" || location == "westus" { | ||
| return fmt.Errorf("Redis Enterprise Cluster (Name %q / Resource Group %q): 'Zones' are not currently supported in the 'West US' or 'Central US EUAP' regions, got %q", resourceId.Name, resourceId.ResourceGroup, location) |
There was a problem hiding this comment.
with the generated parse functions i think this can be
| return fmt.Errorf("Redis Enterprise Cluster (Name %q / Resource Group %q): 'Zones' are not currently supported in the 'West US' or 'Central US EUAP' regions, got %q", resourceId.Name, resourceId.ResourceGroup, location) | |
| return fmt.Errorf("Redis Enterprise Cluster %q: 'Zones' are not currently supported in the 'West US' or 'Central US EUAP' regions, got %q", resourceId, location) |
There was a problem hiding this comment.
Why would the Regions be hard coded? Why not reference a lookup or pivot table instead?
I ask this as the code demonstrated suggests hard coding. The nature of my question is base upon hard coding value adds technical debt to maintain in comparison to a lookup or pivot table containing acceptable configurations.
There was a problem hiding this comment.
Is this validation occurring at the time of deployment or only after a deployment attempt fails?
| name = input.Name | ||
| } | ||
|
|
||
| capacity = *input.Capacity |
There was a problem hiding this comment.
we should nil check this?
azurerm/internal/services/redisenterprise/redis_enterprise_cluster_resource_test.go
Show resolved
Hide resolved
azurerm/internal/services/redisenterprise/redis_enterprise_database_resource.go
Show resolved
Hide resolved
| Optional: true, | ||
| ForceNew: true, | ||
| Default: 10000, | ||
| }, |
| Timeouts: &schema.ResourceTimeout{ | ||
| Create: schema.DefaultTimeout(30 * time.Minute), | ||
| Read: schema.DefaultTimeout(5 * time.Minute), | ||
| Update: schema.DefaultTimeout(30 * time.Minute), |
There was a problem hiding this comment.
| Update: schema.DefaultTimeout(30 * time.Minute), |
|
|
|
This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.49.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
No description provided.