-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_vmware_cluster
#10848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - i've given this a review and left comments inline
@katbyte Thanks for comments. Changes have been pushed. All tests have passed. Please continue your review. CI has failed for some linter problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - left some mroe comments inline
Thanks kt for your comments. All changes have been pushed. Please continue your review. |
Hi kt, thanks for comments. All changes have passed. |
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Partial fix:#9283
=== RUN TestAccVmwareCluster_basic
--- PASS: TestAccVmwareCluster_basic(13926.27s)
=== RUN TestAccVmwareCluster_requiresImport
--- PASS: TestAccVmwareCluster_requiresImport(16861.34s)
=== RUN TestAccVmwareCluster_update
=== PAUSE TestAccVmwareCluster_update
=== CONT TestAccVmwareCluster_update
--- PASS: TestAccVmwareCluster_update (25170.97s)