Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_vmware_cluster #10848

Merged
merged 29 commits into from
Apr 24, 2021
Merged

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Mar 5, 2021

Partial fix:#9283

=== RUN TestAccVmwareCluster_basic
--- PASS: TestAccVmwareCluster_basic(13926.27s)
=== RUN TestAccVmwareCluster_requiresImport
--- PASS: TestAccVmwareCluster_requiresImport(16861.34s)
=== RUN TestAccVmwareCluster_update
=== PAUSE TestAccVmwareCluster_update
=== CONT TestAccVmwareCluster_update
--- PASS: TestAccVmwareCluster_update (25170.97s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - i've given this a review and left comments inline

@yupwei68
Copy link
Contributor Author

@katbyte Thanks for comments. Changes have been pushed. All tests have passed. Please continue your review. CI has failed for some linter problems.
=== RUN TestAccVmwareCluster_basic
=== PAUSE TestAccVmwareCluster_basic
=== CONT TestAccVmwareCluster_basic
--- PASS: TestAccVmwareCluster_basic (22668.31s)
=== RUN TestAccVmwareCluster_requiresImport
=== PAUSE TestAccVmwareCluster_requiresImport
=== CONT TestAccVmwareCluster_requiresImport
--- PASS: TestAccVmwareCluster_requiresImport (25170.23s)
=== RUN TestAccVmwareCluster_update
=== PAUSE TestAccVmwareCluster_update
=== CONT TestAccVmwareCluster_update
--- PASS: TestAccVmwareCluster_update (28203.31s)

@yupwei68 yupwei68 requested a review from katbyte April 19, 2021 01:56
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - left some mroe comments inline

website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Thanks kt for your comments. All changes have been pushed. Please continue your review.

@yupwei68 yupwei68 requested a review from katbyte April 21, 2021 08:26
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vmware_cluster.html.markdown Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Hi kt, thanks for comments. All changes have passed.

@katbyte katbyte added this to the v2.57.0 milestone Apr 24, 2021
@katbyte katbyte merged commit 1bf8dc1 into hashicorp:master Apr 24, 2021
katbyte added a commit that referenced this pull request Apr 24, 2021
@yupwei68 yupwei68 deleted the wyp-avs-cluster branch April 25, 2021 07:35
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants