`*_virtual_machine_scale_set`: Do not force recreation on `rolling_upgrade_policy` and `health_probe_id` update. #10856

favoretti · 2021-03-05T13:14:10Z

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_linux_virtual_machine_scale_set.example will be updated in-place
  ~ resource "azurerm_linux_virtual_machine_scale_set" "example" {
        id                                                = "/subscriptions/4e094144-afbc-420a-8d74-a4a0da618a3b/resourceGroups/vlad-test-resources/providers/Microsoft.Compute/virtualMachineScaleSets/vlad-test-vmss"
        name                                              = "vlad-test-vmss"
        tags                                              = {}
        # (23 unchanged attributes hidden)




      ~ rolling_upgrade_policy {
          ~ max_batch_instance_percent              = 30 -> 20
          ~ max_unhealthy_instance_percent          = 30 -> 20
          ~ max_unhealthy_upgraded_instance_percent = 30 -> 20
          ~ pause_time_between_batches              = "PT0S" -> "PT1S"
        }

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.


Warning: "resource_group_name": [DEPRECATED] This field is no longer used and will be removed in the next major version of the Azure Provider

  on vmss_test.tf line 42, in resource "azurerm_lb_backend_address_pool" "example":
  42: resource "azurerm_lb_backend_address_pool" "example" {


Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

azurerm_linux_virtual_machine_scale_set.example: Modifying... [id=/subscriptions/4e094144-afbc-420a-8d74-a4a0da618a3b/resourceGroups/vlad-test-resources/providers/Microsoft.Compute/virtualMachineScaleSets/vlad-test-vmss]
azurerm_linux_virtual_machine_scale_set.example: Still modifying... [id=/subscriptions/4e094144-afbc-420a-8d74-...virtualMachineScaleSets/vlad-test-vmss, 10s elapsed]
[...]
azurerm_linux_virtual_machine_scale_set.example: Still modifying... [id=/subscriptions/4e094144-afbc-420a-8d74-...virtualMachineScaleSets/vlad-test-vmss, 3m50s elapsed]
azurerm_linux_virtual_machine_scale_set.example: Modifications complete after 3m51s [id=/subscriptions/4e094144-afbc-420a-8d74-a4a0da618a3b/resourceGroups/vlad-test-resources/providers/Microsoft.Compute/virtualMachineScaleSets/vlad-test-vmss]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

…grade_policy` update. Fixes #10851

IamBread · 2021-03-08T08:20:21Z

Hey @jackofallops,
Can we get this merged as it's a minor change and fixes crucial configuration issues?
Regards

jackofallops

Hi @favoretti - Thanks for this PR. It's off to a good start. Could you add tests that cover the update behaviour of these properties now that the can updated in place?
Thanks!

favoretti · 2021-03-08T17:41:43Z

@jackofallops certainly, will do so ASAP.

jackofallops

Hi @favoretti - Thanks for adding the tests, unfortunately it appears the test you've used as the base is actually broken at the destroy stage due to dependency graph not having information to know when to delete the azurerm_lb_rule (it's on our list to fix these tests). I've added a suggestion that should allow the tests to pass for now. The same will be needed in the Windows test.

I didn't see a test for updating health_probe_id, could you add that also?

Thanks!

jackofallops · 2021-03-10T07:27:05Z

azurerm/internal/services/compute/windows_virtual_machine_scale_set_other_resource_test.go

+  admin_username      = "adminuser"
+  admin_password      = "P@ssword1234!"
+
+  disable_password_authentication = false


This property is for Linux VMSS only.

My apologies, should've ran all the tests locally. Doing this now and applying fixes.

azurerm/internal/services/compute/linux_virtual_machine_scale_set_other_resource_test.go

…set_other_resource_test.go Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>

favoretti · 2021-03-10T11:57:05Z

$ make acctests SERVICE='compute' TESTARGS='-run=.*Linux.*otherHealthProbeUpdate' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=.*Linux.*otherHealthProbeUpdate -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 11:07:51 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 11:07:51 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccLinuxVirtualMachineScaleSet_otherHealthProbeUpdate
=== PAUSE TestAccLinuxVirtualMachineScaleSet_otherHealthProbeUpdate
=== CONT  TestAccLinuxVirtualMachineScaleSet_otherHealthProbeUpdate
--- PASS: TestAccLinuxVirtualMachineScaleSet_otherHealthProbeUpdate (486.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	488.121s

$ make acctests SERVICE='compute' TESTARGS='-run=TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 12:40:24 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 12:40:24 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
=== PAUSE TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
=== CONT  TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
--- PASS: TestAccLinuxVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate (615.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	616.872s

I assume windows tests would work too... Haven't ran them though, sorry.

favoretti · 2021-03-10T12:55:03Z

$ make acctests SERVICE='compute' TESTARGS='-run=.*Windows.*otherHealthProbeUpdate' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=.*Windows.*otherHealthProbeUpdate -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 13:25:26 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 13:25:26 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
=== PAUSE TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
=== CONT  TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate (566.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	568.404s

favoretti · 2021-03-10T13:42:03Z

$ make acctests SERVICE='compute' TESTARGS='-run=TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 14:29:06 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 14:29:06 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
=== PAUSE TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
=== CONT  TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherRollingUpgradePolicyUpdate (742.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	744.236s

$ make acctests SERVICE='compute' TESTARGS='-run=.*Windows.*otherHealthProbeUpdate' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=.*Windows.*otherHealthProbeUpdate -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 14:28:58 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 14:28:58 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
=== PAUSE TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
=== CONT  TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherHealthProbeUpdate (581.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	582.717s

katbyte

Thanks @favoretti - LGTM 👍

ghost · 2021-03-12T04:47:12Z

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

ghost · 2021-04-10T14:51:11Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

*_virtual_machine_scale_set: Do not force recreation on `rolling_up…

fa1d3eb

…grade_policy` update. Fixes #10851

ghost added size/XS documentation labels Mar 5, 2021

favoretti added the service/vmss Virtual Machine Scale Sets label Mar 5, 2021

Update to not to recreate on health_probe_id change.

15d45d6

favoretti changed the title ~~*_virtual_machine_scale_set: Do not force recreation on rolling_upgrade_policy update.~~ *_virtual_machine_scale_set: Do not force recreation on rolling_upgrade_policy and health_probe_id update. Mar 5, 2021

favoretti requested a review from tombuildsstuff March 8, 2021 11:20

jackofallops requested changes Mar 8, 2021

View reviewed changes

Add tests

fad35bf

ghost added size/L and removed size/XS labels Mar 9, 2021

terrafmt

d5df512

favoretti requested a review from jackofallops March 9, 2021 17:38

jackofallops requested changes Mar 10, 2021

View reviewed changes

favoretti and others added 2 commits March 10, 2021 10:41

Update azurerm/internal/services/compute/linux_virtual_machine_scale_…

f56b1bd

…set_other_resource_test.go Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>

Update/fix tests

18e17e1

ghost added size/XL and removed size/L labels Mar 10, 2021

favoretti requested a review from jackofallops March 10, 2021 11:57

Ignore extra attribute in windows tests

361f65f

favoretti added 2 commits March 10, 2021 14:16

Tweak windows tests more

40eb5c1

Use a port that's actually healthy for a healthcheck

a77b3c6

jackofallops added this to the v2.51.0 milestone Mar 10, 2021

katbyte approved these changes Mar 10, 2021

View reviewed changes

katbyte merged commit d73de96 into hashicorp:master Mar 10, 2021

katbyte added a commit that referenced this pull request Mar 10, 2021

CHANGEOG.md for #10856

9e804ca

ghost locked as resolved and limited conversation to collaborators Apr 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`*_virtual_machine_scale_set`: Do not force recreation on `rolling_upgrade_policy` and `health_probe_id` update. #10856

`*_virtual_machine_scale_set`: Do not force recreation on `rolling_upgrade_policy` and `health_probe_id` update. #10856

favoretti commented Mar 5, 2021 •

edited

IamBread commented Mar 8, 2021 •

edited

jackofallops left a comment

favoretti commented Mar 8, 2021

jackofallops left a comment

jackofallops Mar 10, 2021

favoretti Mar 10, 2021

favoretti commented Mar 10, 2021

favoretti commented Mar 10, 2021

favoretti commented Mar 10, 2021

katbyte left a comment

ghost commented Mar 12, 2021

ghost commented Apr 10, 2021

*_virtual_machine_scale_set: Do not force recreation on rolling_upgrade_policy and health_probe_id update. #10856

*_virtual_machine_scale_set: Do not force recreation on rolling_upgrade_policy and health_probe_id update. #10856

Conversation

favoretti commented Mar 5, 2021 • edited

IamBread commented Mar 8, 2021 • edited

jackofallops left a comment

Choose a reason for hiding this comment

favoretti commented Mar 8, 2021

jackofallops left a comment

Choose a reason for hiding this comment

jackofallops Mar 10, 2021

Choose a reason for hiding this comment

favoretti Mar 10, 2021

Choose a reason for hiding this comment

favoretti commented Mar 10, 2021

favoretti commented Mar 10, 2021

favoretti commented Mar 10, 2021

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Mar 12, 2021

ghost commented Apr 10, 2021

`*_virtual_machine_scale_set`: Do not force recreation on `rolling_upgrade_policy` and `health_probe_id` update. #10856

`*_virtual_machine_scale_set`: Do not force recreation on `rolling_upgrade_policy` and `health_probe_id` update. #10856

favoretti commented Mar 5, 2021 •

edited

IamBread commented Mar 8, 2021 •

edited