new resource and data source "azurerm_key_vault_managed_hardware_security_module"

[njuCZ]

first pr to fix issue: #10209

1. this resource is only supported in latest preview version: 2020-04-01-preview, and it's going to be GA soon
2. this resource is almost the same with key vault, doc refers to here: https://docs.microsoft.com/en-us/azure/key-vault/managed-hsm/overview
3. api issue that needs to pay attention:
   3.1 soft_delete is always true. If setting to false in the create rest api, it will report error
   3.2 soft_delete_retention_days could not be updated, the backend service will report error
   3.3 purge_protection_enabled could be set in the update rest api, but the response remain the same. this is an issue and I have reported to the service team
   3.4 I have made the above fields forcenew
4. During public preview, the rest api limits we can create only 1 HSM pool(s) per subscription in a region. The acctest is made to run in sequence.

[tombuildsstuff]

hi @njuCZ

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up then we should be able to take another look through and run the tests.

Thanks!

[tombuildsstuff]

this isn't defaulted in the schema - and from memory Terraform intentionally defaults to 7 for the other resource, so we should match that here

[njuCZ]

for the key vault resource, it's also default 90 https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/keyvault/key_vault_resource.go#L196

[njuCZ]

it seems the CI error is because of temporary network break

[njuCZ]

rebase and run the acctest in sequence

[njuCZ]

thanks for the commit

[njuCZ]

@katbyte I have made the acctest run in sequence. Every test has used the func data.ResourceSequentialTest.

[njuCZ]

@katbyte thanks for the suggestions. I have changed the way to run test case. Now all acctest have passed in teamcity

[katbyte]

Thanks @njuCZ - LGTM and once the merge conflict is resolved we can get this merged

[njuCZ]

@katbyte Have rebased and fix the conflicts

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.