Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/eventhub_consumer_group: marking the consumer group as gone if it's gone #10900

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

tombuildsstuff
Copy link
Member

This commit introduces the ID Formatter to the MarkAsGone call so we can conditionally mark this as gone when it's removed from Azure, which ultimately fixes #10898

… gone

This commit introduces the ID Formatter to the MarkAsGone call so we can
conditionally mark this as gone when it's removed from Azure, which ultimately
fixes #10898
@tombuildsstuff tombuildsstuff added this to the v2.51.0 milestone Mar 9, 2021
@tombuildsstuff tombuildsstuff requested a review from a team March 9, 2021 17:27
@ghost ghost added the size/XS label Mar 9, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 7f4f3eb into master Mar 9, 2021
@tombuildsstuff tombuildsstuff deleted the b/eventhub-consumer-group branch March 9, 2021 18:27
tombuildsstuff added a commit that referenced this pull request Mar 9, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform plan fails if Event Hub consumer group was deleted outside of Terraform
2 participants