Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_media_live_event_output #10917

Merged
merged 10 commits into from Apr 13, 2021
Merged

new resource: azurerm_media_live_event_output #10917

merged 10 commits into from Apr 13, 2021

Conversation

jcanizalez
Copy link
Contributor

@jcanizalez jcanizalez commented Mar 10, 2021

Hi
This PR resolves #10813

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully (In order to run Acc Tests successfully PR 10724 for Live Events is required)
  • Check linting

@jcanizalez jcanizalez marked this pull request as ready for review March 10, 2021 14:40
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - i've left some comments inline but overall its looking good

@jcanizalez
Copy link
Contributor Author

Thanks @katbyte I applied your suggestions so you can check again

@jcanizalez jcanizalez requested a review from katbyte April 8, 2021 14:31
@jcanizalez jcanizalez changed the title new resource: azurerm_media_live_output new resource: azurerm_media_live_event_output Apr 8, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - i'm still not sold on keeping output_snap_timestamp - what does timestamp mean in this context? because i would expect a string value, not an int. I presume its in some sort of units and we typically append them to property names so people don't have to look it up in the docs

@jcanizalez
Copy link
Contributor Author

you are right @katbyte is better if we include unit so I appended it

@jcanizalez jcanizalez requested a review from katbyte April 8, 2021 23:08
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - LGTM 👍

@katbyte katbyte added this to the v2.56.0 milestone Apr 13, 2021
@katbyte katbyte merged commit b3e0e45 into hashicorp:master Apr 13, 2021
katbyte added a commit that referenced this pull request Apr 13, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators May 13, 2021
@jcanizalez jcanizalez deleted the azurerm_media_live_output branch May 13, 2021 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Live Outputs in Azure Media Services
2 participants