New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: azurerm_media_live_event_output
#10917
new resource: azurerm_media_live_event_output
#10917
Conversation
…form-provider-azurerm into azurerm_media_live_output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - i've left some comments inline but overall its looking good
…form-provider-azurerm into azurerm_media_live_output
…form-provider-azurerm into azurerm_media_live_output
Thanks @katbyte I applied your suggestions so you can check again |
azurerm_media_live_output
azurerm_media_live_event_output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - i'm still not sold on keeping output_snap_timestamp
- what does timestamp mean in this context? because i would expect a string value, not an int. I presume its in some sort of units and we typically append them to property names so people don't have to look it up in the docs
you are right @katbyte is better if we include unit so I appended it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - LGTM 👍
This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.56.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Hi
This PR resolves #10813
Checked: