Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_certificate - exposing the certificate's secret id #1096

Merged
merged 1 commit into from Apr 9, 2018

Conversation

tombuildsstuff
Copy link
Member

KeyVault Certificates get a matching Secret which has a different URI needed when provisioning VM's. This PR exposes that and adds an end-to-end test case for this scenario. Fixes #1067

$ acctests azurerm TestAccAzureRMVirtualMachine_winRMCerts
=== RUN   TestAccAzureRMVirtualMachine_winRMCerts
--- PASS: TestAccAzureRMVirtualMachine_winRMCerts (599.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	599.469s

@tombuildsstuff tombuildsstuff added this to the 1.3.3 milestone Apr 9, 2018
@tombuildsstuff tombuildsstuff requested a review from a team April 9, 2018 14:55
```
$ acctests azurerm TestAccAzureRMVirtualMachine_winRMCerts
=== RUN   TestAccAzureRMVirtualMachine_winRMCerts
--- PASS: TestAccAzureRMVirtualMachine_winRMCerts (599.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	599.469s
```
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Member Author

Key Vault Certificate tests pass:

screen shot 2018-04-09 at 17 03 05

@tombuildsstuff
Copy link
Member Author

VM tests passed, ignoring some transient errors:

screen shot 2018-04-09 at 19 45 35

@tombuildsstuff tombuildsstuff merged commit b7e2faa into master Apr 9, 2018
@tombuildsstuff tombuildsstuff deleted the keyvault-cert-secreturi branch April 9, 2018 17:46
tombuildsstuff added a commit that referenced this pull request Apr 9, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating windows VM with reference to keyvault certificate URL fails
2 participants