"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_pool" supports "kubelet_config", "linux_os_config" #11119

njuCZ · 2021-03-26T07:44:22Z

two new blocks in node pool: kubelet_config and linux_os_config

linux_os_config contains a sub block "sysctl_config", which could set the the kernel parameters, could refer to https://kubernetes.io/docs/tasks/administer-cluster/sysctl-cluster/

this two blocks are forcenew fields, if we try to update it, the rest api will report error code: CustomKubeletConfigOrCustomLinuxOSConfigCanNotBeChanged.

tombuildsstuff

hi @njuCZ

Thanks for this PR.

Taking a look through here whilst this is off to a good start, the descriptions for these fields don't make sense (in that they don't really specify what this does clearly) or are missing (e.g. "the sysctl value foo.bar") - would you be able to update these?

Thanks!

azurerm/internal/services/containers/kubernetes_cluster_node_pool_resource.go

azurerm/internal/services/containers/kubernetes_cluster_node_pool_resource_test.go

azurerm/internal/services/containers/kubernetes_nodepool.go

tombuildsstuff · 2021-04-06T11:51:53Z

website/docs/r/kubernetes_cluster_node_pool.html.markdown

+
+* `transparent_huge_page_defrag` - (Optional) Specifies the Transparent Huge Page defrag configuration. Possible values are `always`, `defer`, `defer+madvise`, `madvise` and `never`. Changing this forces a new resource to be created.
+
+* `transparent_huge_page_enabled` - (Optional) Specifies the Transparent Huge Page enabled configuration. Possible values are `always`, `madvise` and `never`. Changing this forces a new resource to be created.


this description doesn't make any sense, presumably this toggles if Transparent Huge Pages are enabled?

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/performance_tuning_guide/sect-red_hat_enterprise_linux-performance_tuning_guide-configuring_transparent_huge_pages

so should I rename this property, such as "transparent_huge_page_enabled_config" ?

tombuildsstuff · 2021-04-06T11:55:13Z

website/docs/r/kubernetes_cluster.html.markdown

+
+* `fs_aio_max_nr` - (Optional) The sysctl setting fs.aio-max-nr. Must be between `65536` and `6553500`. Changing this forces a new resource to be created.
+
+* `fs_file_max` - (Optional) The sysctl setting fs.file-max. Must be between `8192` and `12000500`. Changing this forces a new resource to be created.


what does this do?

please refer to https://www.kernel.org/doc/Documentation/sysctl/fs.txt

tombuildsstuff · 2021-04-06T11:55:17Z

website/docs/r/kubernetes_cluster.html.markdown

@@ -454,6 +494,68 @@ A `ssh_key` block supports the following:

 ---

+A `sysctl_config` block supports the following:
+
+* `fs_aio_max_nr` - (Optional) The sysctl setting fs.aio-max-nr. Must be between `65536` and `6553500`. Changing this forces a new resource to be created.


what does this do?

https://www.kernel.org/doc/Documentation/sysctl/fs.txt

tombuildsstuff · 2021-04-06T11:55:43Z

website/docs/r/kubernetes_cluster.html.markdown

+
+* `transparent_huge_page_defrag` - (Optional) Specifies the Transparent Huge Page defrag configuration. Possible values are `always`, `defer`, `defer+madvise`, `madvise` and `never`. Changing this forces a new resource to be created.
+
+* `transparent_huge_page_enabled` - (Optional) Specifies the Transparent Huge Page enabled configuration. Possible values are `always`, `madvise` and `never`. Changing this forces a new resource to be created.


(as below) this description doesn't make sense, should this be "specifies if Transparent Huge Pages are enabled?"

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/performance_tuning_guide/sect-red_hat_enterprise_linux-performance_tuning_guide-configuring_transparent_huge_pages

so should I rename this property, such as "transparent_huge_page_enabled_config" ?

website/docs/r/kubernetes_cluster.html.markdown

njuCZ · 2021-04-07T09:11:50Z

Hi @tombuildsstuff thanks for your review and suggestions, I have added a partial test for those properties.

as for the doc for linuxOSConfig, those properties are used to Tuning linux kernel. Personally I think only professional users should set it, so tell the users which kernel parameter it correspond to is enough and might be more clear.

liammoat · 2021-04-08T13:19:00Z

Related issue: #10038

mbfrahry

Hey @njuCZ! I took another pass over this PR. It looks mostly good but we should update the documentation to point people to where they can find more information about these attributes.

website/docs/r/kubernetes_cluster.html.markdown

azurerm/internal/services/containers/kubernetes_cluster_node_pool_resource.go

azurerm/internal/services/containers/kubernetes_nodepool.go

njuCZ · 2021-05-21T02:34:49Z

@mbfrahry thanks for your suggestions! I have refined this PR.

mbfrahry

This should be good to go once the conflicts are fixed!

…l" - supports "kubelet_config", "linux_os_config"

njuCZ · 2021-06-15T09:28:26Z

@mbfrahry I have rebased the latest code and resolved all conflicts

katbyte

LGTM 🔥

github-actions · 2021-06-18T06:43:53Z

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-07-19T02:07:42Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ghost added size/XXL documentation labels Mar 26, 2021

tombuildsstuff requested changes Apr 6, 2021

View reviewed changes

tombuildsstuff added enhancement service/kubernetes-cluster waiting-response labels Apr 6, 2021

ghost removed the waiting-response label Apr 8, 2021

njuCZ requested a review from tombuildsstuff April 14, 2021 02:44

njuCZ force-pushed the aks_fields branch from 2bc1dd5 to 55296ee Compare April 29, 2021 05:27

mbfrahry requested changes May 20, 2021

View reviewed changes

njuCZ force-pushed the aks_fields branch from 55296ee to 9b402d4 Compare May 21, 2021 02:25

mbfrahry requested changes Jun 10, 2021

View reviewed changes

njuCZ and others added 7 commits June 11, 2021 10:49

"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_poo…

55695fa

…l" - supports "kubelet_config", "linux_os_config"

add kubeletAndLinuxOSConfigPartial test

b54fec1

format

c6bf2a5

update

9782c18

Update kubernetes_cluster_node_pool.html.markdown

2865dc9

rebase

4025bdb

update

6aec5ba

njuCZ force-pushed the aks_fields branch from 7bae203 to 6aec5ba Compare June 15, 2021 09:26

github-actions bot added the size/XL label Jun 15, 2021

katbyte approved these changes Jun 16, 2021

View reviewed changes

katbyte added this to the v2.64.0 milestone Jun 16, 2021

katbyte merged commit 732e21d into hashicorp:master Jun 16, 2021

katbyte added a commit that referenced this pull request Jun 16, 2021

CHANGELOG.md for #11119

27b49a4

katbyte mentioned this pull request Jun 24, 2021

Support for linuxOSConfig on azurerm_kubernetes_cluster_node_pool #10038

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_pool" supports "kubelet_config", "linux_os_config" #11119

"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_pool" supports "kubelet_config", "linux_os_config" #11119

njuCZ commented Mar 26, 2021 •

edited

tombuildsstuff left a comment

tombuildsstuff Apr 6, 2021

njuCZ Apr 7, 2021

tombuildsstuff Apr 6, 2021

njuCZ Apr 7, 2021

tombuildsstuff Apr 6, 2021

njuCZ Apr 7, 2021

tombuildsstuff Apr 6, 2021

njuCZ Apr 7, 2021

njuCZ commented Apr 7, 2021 •

edited

liammoat commented Apr 8, 2021

mbfrahry left a comment

njuCZ commented May 21, 2021

mbfrahry left a comment

njuCZ commented Jun 15, 2021

katbyte left a comment

github-actions bot commented Jun 18, 2021

github-actions bot commented Jul 19, 2021


		* `transparent_huge_page_defrag` - (Optional) Specifies the Transparent Huge Page defrag configuration. Possible values are `always`, `defer`, `defer+madvise`, `madvise` and `never`. Changing this forces a new resource to be created.

		* `transparent_huge_page_enabled` - (Optional) Specifies the Transparent Huge Page enabled configuration. Possible values are `always`, `madvise` and `never`. Changing this forces a new resource to be created.


		* `fs_aio_max_nr` - (Optional) The sysctl setting fs.aio-max-nr. Must be between `65536` and `6553500`. Changing this forces a new resource to be created.

		* `fs_file_max` - (Optional) The sysctl setting fs.file-max. Must be between `8192` and `12000500`. Changing this forces a new resource to be created.

"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_pool" supports "kubelet_config", "linux_os_config" #11119

"azurerm_kubernetes_cluster" and "azurerm_kubernetes_cluster_node_pool" supports "kubelet_config", "linux_os_config" #11119

Conversation

njuCZ commented Mar 26, 2021 • edited

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njuCZ commented Apr 7, 2021 • edited

liammoat commented Apr 8, 2021

mbfrahry left a comment

Choose a reason for hiding this comment

njuCZ commented May 21, 2021

mbfrahry left a comment

Choose a reason for hiding this comment

njuCZ commented Jun 15, 2021

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 18, 2021

github-actions bot commented Jul 19, 2021

njuCZ commented Mar 26, 2021 •

edited

njuCZ commented Apr 7, 2021 •

edited