New Resource: azurerm_app_service_environment_v3

[jackofallops]

This PR introduces the preview resource, App Service Environment V3.

SDK/API coverage is incomplete, so two notable items are missing, but will be added if/when they are supported. (These are Host group deployment, and upgrade preference.)

supersedes #10304
Resolves #9420

[mbfrahry]

Thanks for this @jackofallops! I think this mostly looks good but all three tests here are failing

[jackofallops]

Tests passing:

[tombuildsstuff]

hey @jackofallops

Thanks for pushing those changes - taking a look through on the whole this looks pretty good but I've left some comments inline; if we can fix those up and the tests pass this should otherwise be good to go 👍

Thanks!

[tombuildsstuff]

does the ASE/Gateway subnet name here need to be a fixed name, like some of the other resources?

Suggested change

	resource "azurerm_resource_group" "example" {
	name = "exampleRG1"
	location = "West Europe"
	}
	resource "azurerm_virtual_network" "example" {
	name = "example-vnet1"
	location = azurerm_resource_group.example.location
	resource_group_name = azurerm_resource_group.example.name
	address_space = ["10.0.0.0/16"]
	}
	resource "azurerm_subnet" "ase" {
	name = "asesubnet"
	resource_group_name = azurerm_resource_group.example.name
	virtual_network_name = azurerm_virtual_network.example.name
	address_prefixes = ["10.0.1.0/24"]
	}
	resource "azurerm_subnet" "gateway" {
	name = "gatewaysubnet"
	resource_group_name = azurerm_resource_group.example.name
	virtual_network_name = azurerm_virtual_network.example.name
	address_prefixes = ["10.0.2.0/24"]
	}
	resource "azurerm_app_service_environment_v3" "example" {
	name = "example-ase"
	subnet_id = azurerm_subnet.ase.id
	cluster_setting {
	name = "DisableTls1.0"
	value = "1"
	}
	cluster_setting {
	name = "InternalEncryption"
	value = "true"
	}
	cluster_setting {
	name = "FrontEndSSLCipherSuiteOrder"
	value = "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384_P256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256_P256,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256"
	}
	tags = {
	env = "production"
	terraformed = "true"
	}
	}
	```
	resource "azurerm_resource_group" "example" {
	name = "example-resources"
	location = "West Europe"
	}
	resource "azurerm_virtual_network" "example" {
	name = "example-vnet1"
	location = azurerm_resource_group.example.location
	resource_group_name = azurerm_resource_group.example.name
	address_space = ["10.0.0.0/16"]
	}
	resource "azurerm_subnet" "ase" {
	name = "asesubnet"
	resource_group_name = azurerm_resource_group.example.name
	virtual_network_name = azurerm_virtual_network.example.name
	address_prefixes = ["10.0.1.0/24"]
	}
	resource "azurerm_subnet" "gateway" {
	name = "gatewaysubnet"
	resource_group_name = azurerm_resource_group.example.name
	virtual_network_name = azurerm_virtual_network.example.name
	address_prefixes = ["10.0.2.0/24"]
	}
	resource "azurerm_app_service_environment_v3" "example" {
	name = "example-ase"
	subnet_id = azurerm_subnet.ase.id
	cluster_setting {
	name = "DisableTls1.0"
	value = "1"
	}
	cluster_setting {
	name = "InternalEncryption"
	value = "true"
	}
	cluster_setting {
	name = "FrontEndSSLCipherSuiteOrder"
	value = "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384_P256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256_P256,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256"
	}
	tags = {
	env = "production"
	terraformed = "true"
	}
	}

[tombuildsstuff]

this is force new above, but it's odd this can't be updated?

[jackofallops]

Tags are not part of the update model, and don't appear to be present in the swagger... This could be an oversight, but this behaviour is also present in V1 and V2.

[adamyager]

This PR introduces the preview resource, App Service Environment V3.

SDK/API coverage is incomplete, so two notable items are missing, but will be added if/when they are supported. (These are Host group deployment, and upgrade preference.)

supersedes #10304
Resolves #9420

All is there a thought this would make it into v2.57.0? Seems all buttoned up. Would love to get our hands on this to get ahead of a pending GA date.

[katbyte]

@jackofallops Aside from 1 comment LGTM 👍

stale

[ghost]

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.