Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_mssql_job_agent #11248

Merged
merged 43 commits into from
Apr 16, 2021

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Apr 8, 2021

Adds a new resource for: Elastic SQL Job Agent

The resource itself is very limited so additional resources (e.g. Shared Credential, Job, Steps, Target Groups etc.) will hopefully follow.

r0bnet and others added 24 commits January 6, 2021 13:26
add basic mssql_job_agent
…astic-job-agent

# Conflicts:
#	azurerm/internal/services/mssql/client/client.go
#	azurerm/internal/services/mssql/resourceids.go
* implementation of resource api management email template

* added missing ForceNew and documentation for template_name to have proper behaviour. added acc tests.

* implemented review findings

* removed exporting of apim email template parameters
This data source is a special case where the Resource Group name can
either be specified or looked up, so we need to set the ID once we're
sure we've got the Resource Group, else the segment will be empty in
the Resource ID.

Fixes hashicorp#11220
…1-04-09 (hashicorp#11237)

More details are in hashicorp#11231, although it's hard for us to do much about this ahead
of time unfortunately due to the inability to test these changes (and confirm
which breaking changes are necessary), as such giving some notice this is happening
is the most helpful thing we can do at the moment.
…apping_rule_name` and `data_format` (hashicorp#11157)

zurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format

$ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventGridDataConnection_mappingRule' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventGridDataConnection_mappingRule -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKustoEventGridDataConnection_mappingRule
=== PAUSE TestAccKustoEventGridDataConnection_mappingRule
=== CONT  TestAccKustoEventGridDataConnection_mappingRule
--- PASS: TestAccKustoEventGridDataConnection_mappingRule (1647.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto	1648.919s
Fixes hashicorp#10977
@ghost ghost added the size/XXL label Apr 8, 2021
@ghost ghost added size/XL documentation and removed size/XXL labels Apr 8, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @r0bnet! This PR looks good but it seems like there are some extra bits here that aren't tied to this resource.

We should be good to go once that is taken care of and we talk through the one comment I left!

@ghost ghost added the dependencies label Apr 16, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Sql elastic job agent New Resource: azurerm_mssql_job_agent Apr 16, 2021
@mbfrahry mbfrahry added this to the v2.57.0 milestone Apr 16, 2021
@mbfrahry mbfrahry merged commit c7e41b3 into hashicorp:master Apr 16, 2021
mbfrahry added a commit that referenced this pull request Apr 16, 2021
@r0bnet r0bnet deleted the sql-elastic-job-agent branch April 18, 2021 12:14
katbyte pushed a commit that referenced this pull request Apr 24, 2021
Job Credential resource as part of the Elastic Job Agents.

see: #11248
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants