Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_(linux|windows)_virtual_machine_scale_set - Fix #8454 #11362

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

ArcturusZhang
Copy link
Contributor

Partially fixes #8454

We could do this work around because the service team has confirmed that the default value when absence of this attribute is Regular (details here)

And the service cannot return anything when a property is not set in the request, they call this principal as "PUT-GET consistency".
In some circumstances, this helps - sometimes absence of a property means it was automatically assigned to a value chosen by Azure, and in this way, we will not be getting any diff, which is convenient. They usually will provide another operation to query the actual value of this. An example for this behaviour is the "managed boot diagnostics" here

@ghost ghost added the size/XS label Apr 19, 2021
@jackofallops jackofallops changed the title Update azurerm_linux_virtual_machine_scale_set - Fix #8454 Update azurerm_(linux|windows)_virtual_machine_scale_set - Fix #8454 Apr 19, 2021
@jackofallops jackofallops added the service/vmss Virtual Machine Scale Sets label Apr 19, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang - This LGTM 👍

@jackofallops jackofallops added this to the v2.57.0 milestone Apr 19, 2021
@katbyte katbyte merged commit 84526f9 into hashicorp:master Apr 20, 2021
katbyte added a commit that referenced this pull request Apr 20, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/vmss Virtual Machine Scale Sets size/XS
Projects
None yet
3 participants