Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for infrastructure_encryption_required in azurerm_storage_encryption_scope #11462

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Apr 25, 2021

All tests have passed.

Fixes: #11463

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good aside from one comment

@katbyte katbyte added this to the v2.57.0 milestone Apr 26, 2021
@yupwei68 yupwei68 changed the title Support for require_infrastructure_encryption in azurerm_storage_encryption_scope Support for infrastructure_encryption_required in azurerm_storage_encryption_scope Apr 26, 2021
@yupwei68
Copy link
Contributor Author

Thanks for your comments kt. All tests have passed. Please continue reviewing.

@yupwei68 yupwei68 requested a review from katbyte April 26, 2021 06:58
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🤖

@katbyte katbyte merged commit f69193c into hashicorp:master Apr 26, 2021
katbyte added a commit that referenced this pull request Apr 26, 2021
@yupwei68 yupwei68 deleted the wyp-storage-es2 branch April 28, 2021 02:14
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for require_infrastructure_encryption in azurerm_storage_encryption_scope
2 participants