Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new data source: azurerm_storage_table_entity #11562

Merged
merged 5 commits into from
May 3, 2021
Merged

new data source: azurerm_storage_table_entity #11562

merged 5 commits into from
May 3, 2021

Conversation

alvintang
Copy link
Contributor

No description provided.

katbyte
katbyte approved these changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alvintang - just a couple comments to address and this should be good to merge!

azurerm/internal/services/storage/storage_table_entity_data_source.go
}

id := client.GetResourceID(storageAccountName, tableName, partitionKey, rowKey)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

azurerm/internal/services/storage/storage_table_entity_data_source.go
Required: true,
},
"entity": {
Type: schema.TypeMap,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need t specify the element type here

@katbyte katbyte added this to the v2.58.0 milestone May 3, 2021
@katbyte katbyte changed the title storage table entity data source for #11384 new data source: azurerm_storage_table_entity May 3, 2021
@katbyte katbyte merged commit d340b00 into hashicorp:master May 3, 2021
katbyte added a commit that referenced this pull request May 3, 2021
@katbyte
CHANGELOG.md for #11562
35dcb6b
@alvintang
Copy link
Contributor Author

Thanks @katbyte for the fixes!

@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@alvintang @favoretti
new data source: azurerm_storage_table_entity (hashicorp#11562)
f6586d9 
added data source azurerm_storage_table_entity for hashicorp#11384
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@katbyte @favoretti
CHANGELOG.md for hashicorp#11562
42027eb
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-data-source service/storage size/L
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvintang @katbyte