Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for backup in azurerm_cosmosdb_account #11597

Merged
merged 4 commits into from
May 7, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 6, 2021

Fix: #10557
#8507

=== RUN TestAccCosmosDBAccount_backupPolicy
=== PAUSE TestAccCosmosDBAccount_backupPolicy
=== CONT TestAccCosmosDBAccount_backupPolicy
--- PASS: TestAccCosmosDBAccount_backupPolicy (1513.32s)
=== RUN TestAccCosmosDBAccount_backupPolicyContinuous
=== PAUSE TestAccCosmosDBAccount_backupPolicyContinuous
=== CONT TestAccCosmosDBAccount_backupPolicyContinuous
--- PASS: TestAccCosmosDBAccount_backupPolicyContinuous (1031.44s)

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

website/docs/r/cosmosdb_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_account.html.markdown Outdated Show resolved Hide resolved
@katbyte
Copy link
Collaborator

katbyte commented May 6, 2021

duplicate of #10578

@ghost ghost added size/L and removed size/XL labels May 7, 2021
@yupwei68 yupwei68 changed the title Support for backup_policy in azurerm_cosmosdb_account Support for backup in azurerm_cosmosdb_account May 7, 2021
@katbyte katbyte added this to the v2.58.0 milestone May 7, 2021
@yupwei68
Copy link
Contributor Author

yupwei68 commented May 7, 2021

@katbyte @magodo Thanks for your comments. Tests have passed. Please continue reviewing.

@ghost ghost removed the waiting-response label May 7, 2021
@yupwei68 yupwei68 requested review from magodo and katbyte May 7, 2021 03:10
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 4b9e016 into hashicorp:master May 7, 2021
katbyte added a commit that referenced this pull request May 7, 2021
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-cosmos-acc4 branch May 10, 2021 08:07
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for CosmosDB Continuous Backup Mode
3 participants