Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update network sdk to 2020-11-01 #11627

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented May 8, 2021

Resolves #11707
When update network sdk to 2020-11-01, there's a breaking change : https://azure.microsoft.com/en-us/updates/zone-behavior-change/

To address this breaking change, I use provider API to get available zone list for a location, and use it as default value to keep the behavior unchanged, if user wants to use non-zonal resource, user can set zones = ["no_zone"]

=== RUN   TestAccPublicIpStatic_basic
=== PAUSE TestAccPublicIpStatic_basic
=== CONT  TestAccPublicIpStatic_basic
--- PASS: TestAccPublicIpStatic_basic (167.11s)
=== RUN   TestAccPublicIpStatic_requiresImport
=== PAUSE TestAccPublicIpStatic_requiresImport
=== CONT  TestAccPublicIpStatic_requiresImport
--- PASS: TestAccPublicIpStatic_requiresImport (214.26s)
=== RUN   TestAccPublicIpStatic_zones
=== PAUSE TestAccPublicIpStatic_zones
=== CONT  TestAccPublicIpStatic_zones
--- PASS: TestAccPublicIpStatic_zones (180.77s)
=== RUN   TestAccPublicIpStatic_basic_withDNSLabel
=== PAUSE TestAccPublicIpStatic_basic_withDNSLabel
=== CONT  TestAccPublicIpStatic_basic_withDNSLabel
--- PASS: TestAccPublicIpStatic_basic_withDNSLabel (168.58s)
=== RUN   TestAccPublicIpStatic_standard_withIPv6
=== PAUSE TestAccPublicIpStatic_standard_withIPv6
=== CONT  TestAccPublicIpStatic_standard_withIPv6
--- PASS: TestAccPublicIpStatic_standard_withIPv6 (181.10s)
=== RUN   TestAccPublicIpDynamic_basic_withIPv6
=== PAUSE TestAccPublicIpDynamic_basic_withIPv6
=== CONT  TestAccPublicIpDynamic_basic_withIPv6
--- PASS: TestAccPublicIpDynamic_basic_withIPv6 (149.32s)
=== RUN   TestAccPublicIpStatic_basic_defaultsToIPv4
=== PAUSE TestAccPublicIpStatic_basic_defaultsToIPv4
=== CONT  TestAccPublicIpStatic_basic_defaultsToIPv4
--- PASS: TestAccPublicIpStatic_basic_defaultsToIPv4 (151.45s)
=== RUN   TestAccPublicIpStatic_basic_withIPv4
=== PAUSE TestAccPublicIpStatic_basic_withIPv4
=== CONT  TestAccPublicIpStatic_basic_withIPv4
--- PASS: TestAccPublicIpStatic_basic_withIPv4 (180.71s)
=== RUN   TestAccPublicIpStatic_standard
=== PAUSE TestAccPublicIpStatic_standard
=== CONT  TestAccPublicIpStatic_standard
--- PASS: TestAccPublicIpStatic_standard (181.07s)
=== RUN   TestAccPublicIpStatic_disappears
=== PAUSE TestAccPublicIpStatic_disappears
=== CONT  TestAccPublicIpStatic_disappears
--- PASS: TestAccPublicIpStatic_disappears (173.72s)
=== RUN   TestAccPublicIpStatic_idleTimeout
=== PAUSE TestAccPublicIpStatic_idleTimeout
=== CONT  TestAccPublicIpStatic_idleTimeout
--- PASS: TestAccPublicIpStatic_idleTimeout (167.48s)
=== RUN   TestAccPublicIpStatic_withTags
=== PAUSE TestAccPublicIpStatic_withTags
=== CONT  TestAccPublicIpStatic_withTags
--- PASS: TestAccPublicIpStatic_withTags (229.73s)
=== RUN   TestAccPublicIpStatic_update
=== PAUSE TestAccPublicIpStatic_update
=== CONT  TestAccPublicIpStatic_update
--- PASS: TestAccPublicIpStatic_update (247.72s)
=== RUN   TestAccPublicIpStatic_standardPrefix
=== PAUSE TestAccPublicIpStatic_standardPrefix
=== CONT  TestAccPublicIpStatic_standardPrefix
--- PASS: TestAccPublicIpStatic_standardPrefix (182.38s)
=== RUN   TestAccPublicIpStatic_standardPrefixWithTags
=== PAUSE TestAccPublicIpStatic_standardPrefixWithTags
=== CONT  TestAccPublicIpStatic_standardPrefixWithTags
--- PASS: TestAccPublicIpStatic_standardPrefixWithTags (238.31s)
=== RUN   TestAccPublicIpDynamic_basic
=== PAUSE TestAccPublicIpDynamic_basic
=== CONT  TestAccPublicIpDynamic_basic
--- PASS: TestAccPublicIpDynamic_basic (151.12s)
=== RUN   TestAccPublicIpStatic_importIdError
=== PAUSE TestAccPublicIpStatic_importIdError
=== CONT  TestAccPublicIpStatic_importIdError
--- PASS: TestAccPublicIpStatic_importIdError (182.25s)
=== RUN   TestAccPublicIpStatic_canLabelBe63
=== PAUSE TestAccPublicIpStatic_canLabelBe63
=== CONT  TestAccPublicIpStatic_canLabelBe63
--- PASS: TestAccPublicIpStatic_canLabelBe63 (195.11s)
=== RUN   TestAccPublicIpStatic_ipTags
=== PAUSE TestAccPublicIpStatic_ipTags
=== CONT  TestAccPublicIpStatic_ipTags
--- PASS: TestAccPublicIpStatic_ipTags (166.64s)



=== RUN   TestAccPublicIpPrefix_basic
=== PAUSE TestAccPublicIpPrefix_basic
=== CONT  TestAccPublicIpPrefix_basic
--- PASS: TestAccPublicIpPrefix_basic (190.01s)
=== RUN   TestAccPublicIpPrefix_prefixLength31
=== PAUSE TestAccPublicIpPrefix_prefixLength31
=== CONT  TestAccPublicIpPrefix_prefixLength31
--- PASS: TestAccPublicIpPrefix_prefixLength31 (171.94s)
=== RUN   TestAccPublicIpPrefix_update
=== PAUSE TestAccPublicIpPrefix_update
=== CONT  TestAccPublicIpPrefix_update
--- PASS: TestAccPublicIpPrefix_update (215.31s)
=== RUN   TestAccPublicIpPrefix_disappears
=== PAUSE TestAccPublicIpPrefix_disappears
=== CONT  TestAccPublicIpPrefix_disappears
--- PASS: TestAccPublicIpPrefix_disappears (178.95s)

@ms-henglu ms-henglu force-pushed the ticket-1828240-update-network-sdk-to-the-latest branch from 0929348 to 69d79a8 Compare May 28, 2021 04:20
@jackofallops jackofallops self-assigned this Jun 2, 2021
@jackofallops
Copy link
Member

Hi @ms-henglu - I hope you don't mind, but I've taken a look into this and saw a way to avoid the breaking behavioural change for users and allow them to take advantage of "no zone", so I've updated your PR. Assuming it passes regression tests I'll get another one of the team to review my changes and we should be able to get this merged.

@jackofallops jackofallops added this to the v2.63.0 milestone Jun 3, 2021
@jackofallops jackofallops requested a review from katbyte June 3, 2021 13:34
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jadckofallops - LGTM!

@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass [] in zones of azurerm_public_ip will result a zone-redundant IP instead of a No Zone IP
3 participants