Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed_disk: Option to configure tier on managed disks #11634

Merged
merged 3 commits into from
May 9, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented May 8, 2021

Fixes #11585

Tasks:

  • Implement the option
  • Document the option
  • Run existing Acceptance tests (3 existing failures, regarding KV problems)
  • Create an Acceptance test
  • Validate configuration (option only available for Premium SSDs)

@ghost ghost added size/M and removed size/XS labels May 8, 2021
@aristosvo
Copy link
Collaborator Author

New acctest, testing both setting and updating of tier option:

❯ make acctests SERVICE='compute' TESTARGS='-run=TestAccManagedDisk_attachedTierUpdate'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/compute -run=TestAccManagedDisk_attachedTierUpdate -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/05/08 14:57:51 [DEBUG] not using binary driver name, it's no longer needed
2021/05/08 14:57:52 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccManagedDisk_attachedTierUpdate
=== PAUSE TestAccManagedDisk_attachedTierUpdate
=== CONT  TestAccManagedDisk_attachedTierUpdate
--- PASS: TestAccManagedDisk_attachedTierUpdate (691.37s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute   694.997s

@aristosvo aristosvo marked this pull request as ready for review May 8, 2021 13:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 👍

@katbyte katbyte added this to the v2.59.0 milestone May 9, 2021
@katbyte katbyte merged commit f731aa7 into hashicorp:master May 9, 2021
katbyte added a commit that referenced this pull request May 9, 2021
@aristosvo aristosvo deleted the feature/managed-disk-tier-flag branch May 9, 2021 07:14
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
@aristosvo aristosvo restored the feature/managed-disk-tier-flag branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to configure the "performance tier" for azurerm_managed_disk
2 participants