New Resource : azurerm_servicebus_namespace_disaster_recovery_config (Service Bus Geo DR)

[1-xtra]

As per issue #3136, implemented a disaster resource config resource, following the same pattern as the 'Event Hubs Geo DR config' (which is very similar)

• Added the DR client to the Service Bus clients
• Added parsers and validators for the resource id type
• Implemented resources + tests, following same patterns and naming conventions as per event hubs disaster config resource

Mainly putting this here for a bit of visibility and early feedback. Basic test is passing - still need to add the update tests

Any comments appreciated,

[katbyte]

Thanks @1-xtra - i've given this an initial review with comments left inline

[1-xtra]

Changes done :

$ TF_ACC=1 go test -v ./azurerm/internal/services/servicebus -run=TestAccAzureRMServiceBusNamespacePairing_basic -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/05/10 23:29:37 [DEBUG] not using binary driver name, it's no longer needed
2021/05/10 23:29:37 [DEBUG] not using binary driver name, it's no longer needed
=== RUN TestAccAzureRMServiceBusNamespacePairing_basic
=== PAUSE TestAccAzureRMServiceBusNamespacePairing_basic
=== CONT TestAccAzureRMServiceBusNamespacePairing_basic
--- PASS: TestAccAzureRMServiceBusNamespacePairing_basic (914.15s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/servicebus 914.423s

[katbyte]

Thanks @1-xtra - LGTM 👍

[1-xtra]

Thanks @katbyte - my bad , didn't run-tflint - just done & shall be pushing a commit shortly that fixes the failed check.

I have a vested interest in getting this over the line as a project I'm working on requires it. If anything needs more attention or polishing, just give me a mention & I'm happy to jump in.

[ghost]

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.