New datasource: azurerm_key_vault_secrets

[favoretti]

TODO:

• Add docs

Fixes #12146

2021/06/09 17:27:37 [DEBUG] not using binary driver name, it's no longer needed
2021/06/09 17:27:38 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataSourceKeyVaultSecrets_basic
=== PAUSE TestAccDataSourceKeyVaultSecrets_basic
=== CONT  TestAccDataSourceKeyVaultSecrets_basic
--- PASS: TestAccDataSourceKeyVaultSecrets_basic (351.90s)
PASS

[aristosvo]

@favoretti Nice, quit useful! What about a (prefix) filter option? 🤤😬

[favoretti]

@favoretti Nice, quit useful! What about a (prefix) filter option? 🤤😬

Yah, sure. Regexp, or a list of wanted secrets? And I wanna get HC to weigh in on a generic implementation first and then build on top :) FWIW, this might get thrown out of the window for rework.

[katbyte]

Thanks @favoretti - just a couple questions but other wise looks good!

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault -timeout=1000m -run='TestAccDataSourceKeyVaultSecrets'
2021/06/17 12:41:54 [DEBUG] not using binary driver name, it's no longer needed
2021/06/17 12:41:55 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataSourceKeyVaultSecrets_basic
=== PAUSE TestAccDataSourceKeyVaultSecrets_basic
=== CONT  TestAccDataSourceKeyVaultSecrets_basic
--- PASS: TestAccDataSourceKeyVaultSecrets_basic (612.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault	614.229s

Removed max_results altogether, since its working is... weird. Fetching all names all the time.

[katbyte]

Thanks @favoretti - GLGTM 🍰

[github-actions]

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.