Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: upgrading to v2 of github.com/hashicorp/terraform-plugin-sdk #12209

Merged
merged 28 commits into from
Jun 21, 2021
Merged

dependencies: upgrading to v2 of github.com/hashicorp/terraform-plugin-sdk #12209

merged 28 commits into from
Jun 21, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR does several things, to ultimately upgrade to v2 of the Plugin SDK:

  • Upgrades to v2.6.1 of github.com/hashicorp/terraform-plugin-sdk
  • Upgrades to v0.11.19 of github.com/Azure/go-autorest/autorest
  • Upgrades to v0.9.14 of github.com/Azure/go-autorest/autorest/adal
  • Support for warning diagnostics for the Typed Resources
  • Updates the Plugin SDK wrapper to use the Context-aware methods in the Plugin SDK
  • Removes the vendored AzureAD provider, since this is no longer needed

Since this only changes code outside of the ./azurerm/internal/services package this shouldn't conflict with open PR's

@tombuildsstuff tombuildsstuff added this to the v2.65.0 milestone Jun 15, 2021
@tombuildsstuff tombuildsstuff self-assigned this Jun 15, 2021
@tombuildsstuff
Copy link
Contributor Author

App Config tests pass:

Screenshot 2021-06-15 at 11 04 11

@tombuildsstuff
Copy link
Contributor Author

Resources passes too:

Screenshot 2021-06-15 at 11 10 20

@tombuildsstuff tombuildsstuff added the upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc) label Jun 16, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.65.0, Blocked Jun 16, 2021
@tombuildsstuff tombuildsstuff modified the milestones: Blocked, v2.65.0 Jun 18, 2021
@tombuildsstuff tombuildsstuff marked this pull request as ready for review June 18, 2021 07:55
@tombuildsstuff tombuildsstuff requested a review from a team June 18, 2021 07:55
@tombuildsstuff
refactor: updating the imports for Plugin SDK2
52e7f97
@tombuildsstuff
dependencies: vendoring v2.6.1 of github.com/hashicorp/terraform-plug…
a897e81 
…in-sdk
@tombuildsstuff
refactor: minimum viable changes necessary for PluginSDK2 to work
651ad5b
@tombuildsstuff
updating the task list
9dd72c3
@tombuildsstuff
removing the azuread provider
1fa7eb7
@tombuildsstuff
go mod vendor
46b191f
@tombuildsstuff
refactor: removing the dependency on github.com/hashicorp/terraform-p…
80169b5 
…lugin-sdk/acctest
@tombuildsstuff
removing github.com/hashicorp/terraform-plugin-sdk/helper/acctest
2a760b1
@tombuildsstuff
updating the todo's
8634cd9
@tombuildsstuff
typed resources: support for diagnostics
4c0dc0e
@tombuildsstuff
updating github.com/Azure/go-autorest to latest
d8ec3b4
@tombuildsstuff
reverting a couple of replacement issues
e71fbf3
@tombuildsstuff
sdk: fixing the unit tests
33d0bf6 
Plugin SDKv2 now correctly outputs the `%` value which was omitted from Plugin SDK v1
so patching the tests to account for it
@tombuildsstuff
refactor: updating WaitForState to use WaitForStateContext
33537dd
@tombuildsstuff
linting fixes
187eb7c
manicminer
manicminer approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff LGTM! Just spotted a couple of import reorderings.

azurerm/internal/acceptance/testcase.go Outdated Show resolved Hide resolved
azurerm/internal/provider/provider.go Outdated Show resolved Hide resolved
azurerm/internal/provider/provider.go Show resolved Hide resolved
azurerm/internal/sdk/wrapper_resource.go Outdated Show resolved Hide resolved
tombuildsstuff and others added 5 commits June 21, 2021 16:14
@tombuildsstuff @manicminer
Update azurerm/internal/acceptance/testcase.go
5d83b6f 
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
@tombuildsstuff @manicminer
Update azurerm/internal/provider/provider.go
4dbd6e5 
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
@tombuildsstuff @manicminer
Update azurerm/internal/provider/provider.go
bfdd572 
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
@tombuildsstuff @manicminer
Update azurerm/internal/sdk/wrapper_resource.go
dd00b26 
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
@tombuildsstuff
fixing the linting
4be9bc0
@tombuildsstuff tombuildsstuff merged commit 5553d2c into master Jun 21, 2021
@tombuildsstuff tombuildsstuff deleted the f/plugin-sdk2 branch June 21, 2021 14:49
tombuildsstuff added a commit that referenced this pull request Jun 21, 2021
@tombuildsstuff
updating to include #12209
192f624
@github-actions
Copy link

This functionality has been released in v2.65.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees

@tombuildsstuff tombuildsstuff

Labels
dependencies documentation size/XL upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc)
Projects
None yet
Milestone
v2.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @manicminer