Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_trigger_blob_event: Support for activation #12644

Conversation

aristosvo
Copy link
Collaborator

Fixes #12621

Acceptance Tests

❯ make acctests SERVICE='datafactory' TESTARGS='-run=TestAccDataFactoryTriggerBlobEvent'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -run=TestAccDataFactoryTriggerBlobEvent -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactoryTriggerBlobEvent_basic
=== PAUSE TestAccDataFactoryTriggerBlobEvent_basic
=== RUN   TestAccDataFactoryTriggerBlobEvent_requiresImport
=== PAUSE TestAccDataFactoryTriggerBlobEvent_requiresImport
=== RUN   TestAccDataFactoryTriggerBlobEvent_complete
=== PAUSE TestAccDataFactoryTriggerBlobEvent_complete
=== RUN   TestAccDataFactoryTriggerBlobEvent_update
=== PAUSE TestAccDataFactoryTriggerBlobEvent_update
=== RUN   TestAccDataFactoryTriggerBlobEvent_startStop
=== PAUSE TestAccDataFactoryTriggerBlobEvent_startStop
=== CONT  TestAccDataFactoryTriggerBlobEvent_basic
=== CONT  TestAccDataFactoryTriggerBlobEvent_update
=== CONT  TestAccDataFactoryTriggerBlobEvent_startStop
=== CONT  TestAccDataFactoryTriggerBlobEvent_complete
=== CONT  TestAccDataFactoryTriggerBlobEvent_requiresImport
--- PASS: TestAccDataFactoryTriggerBlobEvent_basic (173.05s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_complete (182.11s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_requiresImport (188.63s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_startStop (264.47s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_update (324.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory 325.861s

@aristosvo aristosvo force-pushed the feature/activate-azurerm_data_factory_trigger_blob_event branch from 0bb6579 to 525741a Compare July 19, 2021 11:19
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aristosvo

Thanks for this PR.

I've taken a look through and left a couple of minor comments inline but this otherwise LGTM 👍

Thanks!

@aristosvo
Copy link
Collaborator Author

aristosvo commented Jul 19, 2021

Thanks a lot for your quick review! Addressed, tests still passing:

❯ make acctests SERVICE='datafactory' TESTARGS='-run=TestAccDataFactoryTriggerBlobEvent'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -run=TestAccDataFactoryTriggerBlobEvent -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactoryTriggerBlobEvent_basic
=== PAUSE TestAccDataFactoryTriggerBlobEvent_basic
=== RUN   TestAccDataFactoryTriggerBlobEvent_requiresImport
=== PAUSE TestAccDataFactoryTriggerBlobEvent_requiresImport
=== RUN   TestAccDataFactoryTriggerBlobEvent_complete
=== PAUSE TestAccDataFactoryTriggerBlobEvent_complete
=== RUN   TestAccDataFactoryTriggerBlobEvent_update
=== PAUSE TestAccDataFactoryTriggerBlobEvent_update
=== RUN   TestAccDataFactoryTriggerBlobEvent_startStop
=== PAUSE TestAccDataFactoryTriggerBlobEvent_startStop
=== CONT  TestAccDataFactoryTriggerBlobEvent_basic
=== CONT  TestAccDataFactoryTriggerBlobEvent_update
=== CONT  TestAccDataFactoryTriggerBlobEvent_complete
=== CONT  TestAccDataFactoryTriggerBlobEvent_requiresImport
=== CONT  TestAccDataFactoryTriggerBlobEvent_startStop
--- PASS: TestAccDataFactoryTriggerBlobEvent_basic (168.97s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_requiresImport (181.14s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_complete (184.45s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_update (317.34s)
--- PASS: TestAccDataFactoryTriggerBlobEvent_startStop (329.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory   330.563s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 🌈

@katbyte katbyte merged commit 8602bb5 into hashicorp:master Jul 27, 2021
katbyte added a commit that referenced this pull request Jul 27, 2021
@github-actions
Copy link

This functionality has been released in v2.70.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for start/activation of Azure Data Factory blob event-based triggers
3 participants