Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysisservices: refactoring to use an Embedded SDK #12771

Merged
merged 4 commits into from Jul 29, 2021

Conversation

tombuildsstuff
Copy link
Member

This PR refactors the AnalysisServices package over to using an Embedded SDK

@tombuildsstuff
Copy link
Member Author

Tests pass:

Screenshot 2021-07-28 at 19 47 13

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@tombuildsstuff tombuildsstuff merged commit a236ada into master Jul 29, 2021
@tombuildsstuff tombuildsstuff deleted the f/analysisservices-embedded-sdk branch July 29, 2021 09:51
tombuildsstuff added a commit that referenced this pull request Jul 29, 2021
@github-actions
Copy link

This functionality has been released in v2.70.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants