Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resource_arm_app_service_plan Validation to Allow Underscore #1351

Merged
merged 3 commits into from
Jun 6, 2018

Conversation

shanepoint
Copy link
Contributor

Also updated example and added validation of character limits.

Fixes #1336

@shanepoint shanepoint force-pushed the b-appserviceplan-validation branch from 4d3189f to a4956d5 Compare June 6, 2018 05:39
@katbyte katbyte self-requested a review June 6, 2018 16:35
@katbyte katbyte added this to the 1.7.0 milestone Jun 6, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shanepoint,

Thank you for opening this PR to add additional validation. LGTM 👍

@katbyte katbyte merged commit 47dcea0 into hashicorp:master Jun 6, 2018
katbyte added a commit that referenced this pull request Jun 6, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax naming requirements of app_service_plan
2 participants