Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_definition: role_definition_id is now optional #1378

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 11, 2018

Fixes #1371

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the minor doc fix!

@@ -37,7 +36,7 @@ resource "azurerm_role_definition" "test" {

The following arguments are supported:

* `role_definition_id` - (Required) A unique UUID/GUID which identifies this role. Changing this forces a new resource to be created.
* `role_definition_id` - (Optional) A unique UUID/GUID which identifies this role - one will be generated if not specified.. Changing this forces a new resource to be created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra period one will be generated if not specified..

@katbyte katbyte merged commit e4e05b2 into master Jun 12, 2018
@katbyte katbyte deleted the f-role_definition-auto_gen_name branch June 12, 2018 15:13
katbyte added a commit that referenced this pull request Jun 12, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: automatically generate UUID for azurerm_role_definition
2 participants