Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from net.dial to http.get so environment proxy settings can be picked up #1393

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

lstolyarov
Copy link
Contributor

@lstolyarov lstolyarov commented Jun 14, 2018

This fixes #604

Tested with and without a proxy.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lstolyarov,

Thank you so much for this contribution! It LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Jun 14, 2018

test pass:
screen shot 2018-06-14 at 10 29 23

(fail test is not new)

@katbyte katbyte merged commit a5e87a4 into hashicorp:master Jun 14, 2018
@katbyte katbyte added this to the 1.7.0 milestone Jun 14, 2018
katbyte added a commit that referenced this pull request Jun 14, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create keyvault behind proxy as net.dial does not use proxy
3 participants