Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers: fixing test failures #1431

Merged
merged 2 commits into from
Jun 24, 2018
Merged

Helpers: fixing test failures #1431

merged 2 commits into from
Jun 24, 2018

Conversation

tombuildsstuff
Copy link
Member

Fixing a test failure identified whilst running the tests for #1409 - fixes this:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualNetworkGateway_vpnClientConfig
--- FAIL: TestAccAzureRMVirtualNetworkGateway_vpnClientConfig (0.18s)
    testing.go:513: Step 0 error: config is invalid: azurerm_virtual_network_gateway.test: "vpn_client_configuration.0.radius_server_address" is not a valid IP4 address: '"1.2.3.4"`
FAIL

The validation functions also now pass:

$ go test -v ./azurerm/helpers/validate/
=== RUN   TestHelper_Validate_Ip4Address
--- PASS: TestHelper_Validate_Ip4Address (0.00s)
=== RUN   TestHelper_Validate_MacAddress
--- PASS: TestHelper_Validate_MacAddress (0.00s)
=== RUN   TestHelper_Validate_RFC3339Time
--- PASS: TestHelper_Validate_RFC3339Time (0.00s)
=== RUN   TestHelper_Validate_Rfc3339DateInFutureBy
--- PASS: TestHelper_Validate_Rfc3339DateInFutureBy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.027s

```
$ go test -v .
=== RUN   TestHelper_Validate_Ip4Address
--- PASS: TestHelper_Validate_Ip4Address (0.00s)
=== RUN   TestHelper_Validate_MacAddress
--- PASS: TestHelper_Validate_MacAddress (0.00s)
=== RUN   TestHelper_Validate_RFC3339Time
--- PASS: TestHelper_Validate_RFC3339Time (0.00s)
=== RUN   TestHelper_Validate_Rfc3339DateInFutureBy
--- PASS: TestHelper_Validate_Rfc3339DateInFutureBy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.026s
```
```
$ go test -v ./azurerm/helpers/validate/
=== RUN   TestHelper_Validate_Ip4Address
--- PASS: TestHelper_Validate_Ip4Address (0.00s)
=== RUN   TestHelper_Validate_MacAddress
--- PASS: TestHelper_Validate_MacAddress (0.00s)
=== RUN   TestHelper_Validate_RFC3339Time
--- PASS: TestHelper_Validate_RFC3339Time (0.00s)
=== RUN   TestHelper_Validate_Rfc3339DateInFutureBy
--- PASS: TestHelper_Validate_Rfc3339DateInFutureBy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.027s
```
@tombuildsstuff
Copy link
Member Author

The VPN Gateway year passes:

[TestAccAzureRMVirtualNetworkGateway_vpnClientConfig] [Test Output]
=== RUN   TestAccAzureRMVirtualNetworkGateway_vpnClientConfig
--- PASS: TestAccAzureRMVirtualNetworkGateway_vpnClientConfig (1908.03s)
PASS

@tombuildsstuff tombuildsstuff merged commit a6f0dba into master Jun 24, 2018
@tombuildsstuff tombuildsstuff deleted the test-failures branch June 24, 2018 12:25
tombuildsstuff added a commit that referenced this pull request Jun 24, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants