resource/application_Gateway: Add minimum_servers to probe resource #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
approved these changes
Jul 6, 2018
| @@ -1172,6 +1178,7 @@ func expandApplicationGatewayProbes(d *schema.ResourceData) *[]network.Applicati | |||
| interval := int32(data["interval"].(int)) | |||
| timeout := int32(data["timeout"].(int)) | |||
| unhealthyThreshold := int32(data["unhealthy_threshold"].(int)) | |||
| minServers := int32(data["minimum_servers"].(int)) | |||
There was a problem hiding this comment.
can we update one of the existing tests to set this to 2 / verify this assumption?
There was a problem hiding this comment.
sorry for the issues with the names :)
This was missing from the original implementation and is required if you want to manually mark servers as active
stack72
force-pushed
the
app_gateway_probe_min_servers
branch
from
cf269c5
to
3078e0d
Compare
katbyte
added a commit
that referenced
this pull request
Jul 7, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing from the original implementation and is required if
you want to manually mark servers as active