Fix to not drop MySQL and PostgreSQL DB when storage_mb value is changed

[WodansSon]

Fixes issue #1522
Test Results

(fixes #1522 )

[JunyiYi]

Simple change. LGTM

[tombuildsstuff]

@jeffreyCline can you run all of the Postgres/MySQL tests for this?

[tombuildsstuff]

Once the docs issue is fixed this otherwise LGTM 👍🏼

[tombuildsstuff]

Can we update the docs to mention that this is no longer ForceNew? (And above)

[WodansSon]

Yeah, I thought about that after I did the initial push. I'll update those now.

[WodansSon]

I just looked at the documentation and the original text does not mention that it will ForceNew so I believe this is a no op:

• storage_mb - (Required) Max storage allowed for a server. Possible values are between 5120 MB(5GB) and 1048576 MB(1TB) for the Basic SKU and between 5120 MB(5GB) and 4194304 MB(4TB) for General Purpose/Memory Optimized SKUs. For more information see the product documentation.

[katbyte]

@tombuildsstuff I am running them now

[katbyte]

Hi @jeffreyCline,

Outside the docs requiring an update this LGTM 👍

[katbyte]

tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!