New Resource - azurerm_servicebus_queue_authorization_rule #1543
Conversation
katbyte
force-pushed
the
f-servicebus-authrules
branch
from
2b5fb8d
to
f3e0bb6
Compare
katbyte
changed the title
katbyte
force-pushed
the
f-servicebus-authrules
branch
from
2a48514
to
7e8779a
Compare
katbyte
force-pushed
the
f-servicebus-authrules
branch
from
7e8779a
to
ff93265
Compare
|
|
||
| ## Import | ||
|
|
||
| ServiceBus Namespace authorization rules can be imported using the `resource id`, e.g. |
There was a problem hiding this comment.
ServiceBus Namespace -> ServiceBus Queue
|
|
||
| The following attributes are exported: | ||
|
|
||
| * `id` - The ServiceBus Topic ID. |
There was a problem hiding this comment.
I think this should be The ID of the ServiceBus Queue Authorization Rule?
|
|
||
| * `secondary_key` - The Secondary Key for the ServiceBus Namespace authorization Rule. | ||
|
|
||
| * `secondary_connection_string` - The Secondary Connection String for the ServiceBus Namespace authorization Rule. |
There was a problem hiding this comment.
Namespace -> Queue in all 4 of these?
|
|
||
| * `namespace_name` - (Required) Specifies the name of the ServiceBus namespace. Changing this forces a new resource to be created. | ||
|
|
||
| * `namespace_name` - (Required) Specifies the name of the ServiceBus queue. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
this should be queue_name?
|
|
||
| * `send` - (Optional) Grants send access to this this Authorization Rule. Defaults to `false`. | ||
|
|
||
| * `manage` - (Optional) Grants manage access to this this Authorization Rule. When this property is `true` - both `listen` and `send` must be too. Defaults to `false`. |
There was a problem hiding this comment.
this this in all 3 of these
| d.SetId("") | ||
| return nil | ||
| } | ||
| return fmt.Errorf("Error making Read request on Azure ServiceBus Queue Authorization Rule %s: %+v", name, err) |
There was a problem hiding this comment.
can we raise the other info here? IMO the names are likely to be used across resources
| @@ -73,6 +87,67 @@ func FlattenServiceBusAuthorizationRuleRights(rights *[]servicebus.AccessRights) | |||
| } | |||
|
|
|||
| //shared schema | |||
| func MergeSchema(a map[string]*schema.Schema, b map[string]*schema.Schema) map[string]*schema.Schema { | |||
There was a problem hiding this comment.
since this isn't being used outside of this package, this could probably become a private method?
tombuildsstuff
force-pushed
the
f-servicebus-authrules
branch
from
0c02d0c
to
4632f48
Compare
tombuildsstuff
force-pushed
the
f-servicebus-authrules
branch
from
4632f48
to
1adae28
Compare
|
Tests pass:
|
tombuildsstuff
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Also adds additional validation to other service bus resources.