New Resource: azurerm_log_profile #1792

liemnotliam · 2018-08-19T13:56:43Z

New Log Profile resource to address issue #1175

* Update config and provider. * Add data and resource schemas. * Add docs. * Add acceptance tests.

* Normalise locations. * Set storage account and service bus IDs directly.

JunyiYi

Hi @liemnotliam , I have looked through your code and had several small comments.

JunyiYi · 2018-08-22T01:06:12Z

azurerm/resource_arm_log_profile.go

+			"name": {
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,


Please add the non-nil validation similar to this one. #Closed

JunyiYi · 2018-08-22T01:24:39Z

azurerm/resource_arm_log_profile.go

+	categories := expandLogProfileCategories(d)
+	locations := expandLogProfileLocations(d)
+	retentionPolicy, err := expandAzureRmLogProfileRetentionPolicy(d)
+	if err != nil {


~~Actually you can combine this line and the next line together. This comment also applies to the several similar cases below.~~ #Closed

Combine them in which way, could you clarify?

Nevermind, this suggestion doesn't apply anymore. #Closed

JunyiYi

Hi @liemnotliam , Thanks for your contribution. I took a detailed look at your code and had provided some more detailed comments. And by the way, TestAccAzureRMLogProfile_servicebus case failed with message After applying this step, the plan was not empty.

azurerm/data_source_log_profile.go

JunyiYi · 2018-08-23T00:20:29Z

azurerm/data_source_log_profile.go

+		d.Set("storage_account_id", props.StorageAccountID)
+		d.Set("service_bus_rule_id", props.ServiceBusRuleID)
+
+		locations := make([]string, len(*props.Locations))


Although defined as required in Azure REST spec, we might still need to nil check props.Locations to prevent potential crash.

if props.Locations != nil { locations := … … d.Set("locations", locations) } ``` #Closed

JunyiYi · 2018-08-23T00:23:08Z

azurerm/import_arm_log_profile_test.go

+	"github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccAzureRMLogProfile_importBasic(t *testing.T) {


Our latest best practice for import tests is to move them to the normal test cases. Take this action group test as an example. #Closed

azurerm/resource_arm_log_profile.go

JunyiYi · 2018-08-23T00:41:00Z

azurerm/resource_arm_log_profile.go

+	locations := []string{}
+
+	for _, location := range logProfileLocations {
+		locations = append(locations, location.(string))


Maybe azureRMNormalizeLocation(location.(string)) here. #Closed

JunyiYi · 2018-08-23T01:15:41Z

azurerm/resource_arm_log_profile_test.go

+}
+
+resource "azurerm_log_profile" "test" {
+	name = "basic"


Append random number to name to prevent name conflict when running tests in parallel. #Closed

The acceptance tests are combined into one run now. Azure doesn't allow for more than one log profile in a subscription so these tests shouldn't run in parallel.

JunyiYi · 2018-08-23T01:17:01Z

azurerm/resource_arm_log_profile_test.go

+}
+
+resource "azurerm_servicebus_namespace" "test" {
+  name                = "a%s"


Naming convention acctestsbns-%s #Closed

JunyiYi · 2018-08-23T01:17:11Z

azurerm/resource_arm_log_profile_test.go

+}
+
+resource "azurerm_servicebus_namespace_authorization_rule" "test" {
+  name                = "%s"


Naming convention acctestsbrule-%s #Closed

website/docs/r/log_profile.html.markdown

website/docs/d/log_profile.html.markdown

* Move import test to normal test case. * Update resource names.

* Make retention policy days optional, which defaults to 0. * Add nil checks. * Add flatten locations function. * Refactor based on conventions.

JunyiYi

Looks good to me except for the Retry stuffs, that might be an API issue and should be fixed on their side. All other stuffs just fine.

liemnotliam · 2018-08-28T09:51:28Z

The retries are being done in several other places that wait for the resource to become available:

There's more examples, but the retry logic is quite common for dealing with the quirks of the Azure API. If that's the only issue, is this PR ok to be approved then @JunyiYi ?

JunyiYi

If that is the case, yes @liemnotliam , I'm OK with other code logic here.

liemnotliam · 2018-09-04T09:36:44Z

Thanks for the comments and feedback @JunyiYi ! Is there scope for this to be included in the v1.14.0 from the Future milestone?

tombuildsstuff

hey @liemnotliam

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left some comments in-line - but this is mostly looking good. If we can fix those up we should be able to kick off the tests and see how this looks 👍

Thanks!

tombuildsstuff · 2018-09-25T23:45:25Z

azurerm/data_source_log_profile.go

+		d.Set("categories", props.Categories)
+
+		d.Set("locations", flattenAzureRmLogProfileLocations(props.Locations))
+		d.Set("retention_policy", flattenAzureRmLogProfileRetentionPolicy(props.RetentionPolicy))


singe both of these calls sets complex objects; can we check for errors here? e.g.

if err := d.Set("locations", flattenAzureRmLogProfileLocations(props.Locations)); err != nil { return fmt.Errorf("Error flattening `locations`: %+v", err) } if err := d.Set("retention_policy", flattenAzureRmLogProfileRetentionPolicy(props.RetentionPolicy)); err != nil { return fmt.Errorf("Error flattening `retention_policy `: %+v", err) }

tombuildsstuff · 2018-09-25T23:56:44Z

azurerm/data_source_log_profile.go

+	resp, err := client.Get(ctx, name)
+	if err != nil {
+		if utils.ResponseWasNotFound(resp.Response) {
+			d.SetId("")


can we remove the d.SetId("") here?

tombuildsstuff · 2018-09-26T00:16:56Z

azurerm/data_source_log_profile_test.go

+		data "azurerm_log_profile" "test" {
+			name = "${azurerm_log_profile.test.name}"
+		}
+	`, rInt, location, rString, rInt, location)


minor can we switch over to using spaces rather than tabs for indentations here?

tombuildsstuff · 2018-09-26T00:16:58Z

azurerm/data_source_log_profile_test.go

+		data "azurerm_log_profile" "test" {
+			name = "${azurerm_log_profile.test.name}"
+		}
+	`, rInt, location, rString, rInt, location)


minor can we switch over to using spaces rather than tabs for indentations here?

tombuildsstuff · 2018-09-26T00:19:40Z

azurerm/provider.go

@@ -188,6 +189,7 @@ func Provider() terraform.ResourceProvider {
 			"azurerm_local_network_gateway":                   resourceArmLocalNetworkGateway(),
 			"azurerm_log_analytics_solution":                  resourceArmLogAnalyticsSolution(),
 			"azurerm_log_analytics_workspace":                 resourceArmLogAnalyticsWorkspace(),
+			"azurerm_log_profile":                             resourceArmLogProfile(),


can we make this azurerm_monitor_log_profile to match the other monitoring resources?

tombuildsstuff · 2018-09-26T02:33:44Z

website/docs/d/log_profile.html.markdown

+
+* `categories` - List of categories of the logs.
+
+* `retention_policy`- A retention policy for how long Activity Logs are retained in the storage account.


Can we update this to be:

* `retention_policy` - a `retention_policy` block as documented below

tombuildsstuff · 2018-09-26T02:34:41Z

website/docs/r/log_profile.html.markdown

+    "westus",
+    "northcentralus",
+    "southcentralus",
+    "global",


for the purposes of this example we should be able to simplify this to just global?

tombuildsstuff · 2018-09-26T02:35:54Z

azurerm/data_source_log_profile.go

+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"service_bus_rule_id": {


can we make this servicebus_rule_id to match the other resources/Azure branding?

tombuildsstuff · 2018-09-26T02:36:48Z

azurerm/data_source_log_profile.go

+
+	if props := resp.LogProfileProperties; props != nil {
+		d.Set("storage_account_id", props.StorageAccountID)
+		d.Set("service_bus_rule_id", props.ServiceBusRuleID)


can we make this servicebus_rule_id to match the other resources/Azure branding?

tombuildsstuff · 2018-09-26T02:37:13Z

azurerm/resource_arm_log_profile.go

+				Optional:     true,
+				ValidateFunc: azure.ValidateResourceIDOrEmpty,
+			},
+			"service_bus_rule_id": {


can we make this servicebus_rule_id to match the other resources/Azure branding?

* Renamed log profile resource to `azurerm_monitor_log_profile` * Renamed service bus rule id field to match azurerm provider branding * Add more detailed error messages * Update locations and categories type to Set * Use alt test location to support tests in Azure China, gov't, etc.

liemnotliam · 2018-10-12T16:26:26Z

Hey @tombuildsstuff I've made changes based on your comments and this PR is ready to be reviewed again

katbyte

Hi @liemnotliam,

I've taken a quick look and it mostly LGTM aside from a few comments, none that would block this. However the tests are currently failing:

------- Stdout: -------
=== RUN   TestAccAzureRMMonitorLogProfile
=== RUN   TestAccAzureRMMonitorLogProfile/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/servicebus
=== RUN   TestAccAzureRMMonitorLogProfile/basic/complete
=== RUN   TestAccAzureRMMonitorLogProfile/basic/disappears
--- FAIL: TestAccAzureRMMonitorLogProfile (769.60s)
    --- FAIL: TestAccAzureRMMonitorLogProfile/basic (769.60s)
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/basic (93.57s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: Error Creating/Updating Log Profile "acctestlp-9142375735542561086": insights.LogProfilesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/servicebus (433.14s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: Error Creating/Updating Log Profile "acctestlp-2367274785140308499": insights.LogProfilesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/complete (159.29s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: Error Creating/Updating Log Profile "acctestlp-5022616636028035825": insights.LogProfilesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/disappears (83.60s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:
        		
        		* azurerm_monitor_log_profile.test: Error Creating/Updating Log Profile "acctestlp-290585701865438756": insights.LogProfilesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
FAIL

I'll take a closer look later today/tomorrow but could this be related to only one log profile being able to be provisioned per subscription?

katbyte · 2018-10-15T19:40:48Z

azurerm/data_source_monitor_log_profile_test.go

+
+func testAccDataSourceAzureRMMonitorLogProfile_storageaccountConfig(rInt int, rString string, location string) string {
+	return fmt.Sprintf(`
+        resource "azurerm_resource_group" "test" {


Very minor and not a blocker, but could we left align theres:

return fmt.Sprintf(` resource "azurerm_resource_group" "test" {

katbyte · 2018-10-15T19:42:59Z

website/docs/r/monitor_log_profile.html.markdown

+page_title: "Azure Resource Manager: azurerm_monitor_log_profile"
+sidebar_current: "docs-azurerm-resource-monitor-log-profile"
+description: |-
+  Creates a Log Profile.


This should be Manages a

katbyte · 2018-10-15T19:43:11Z

website/docs/r/monitor_log_profile.html.markdown

+
+# azurerm_monitor_log_profile
+
+Creates a [Log Profile](https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/monitoring-overview-activity-logs#export-the-activity-log-with-a-log-profile). A Log Profile configures how Activity Logs are exported.


As should this

liemnotliam · 2018-10-16T10:52:41Z

Hey @katbyte ,

I've made the changes based on your comments.

The 409 conflict error typically indicates that there's an existing log profile so it can't create another due to that 1 log profile per subscription limitation.

katbyte · 2018-10-16T18:58:42Z

@liemnotliam,

Cleaning out our subscription and trying again. However if this is the case having the datasource and resource tests separate is going to cause issues with our nightly build, they will either need to be combined or locked so they don't run at the same time.

katbyte · 2018-10-16T23:59:40Z

@liemnotliam,

I am still unable to get it to work on our subscription. I suspect there is a log profile kicking around somewhere. Are you aware of where to find this in the portal?

However running the tests on another subscription, the test is showing a non-empty plan:

testing.go:513: Step 0 error: After applying this step, the plan was not empty:
               
               DIFF:
               
               UPDATE: azurerm_monitor_log_profile.test
                 locations.1790160812: "" => "westeurope"
                 locations.574794058:  "westeurope" => ""

liemnotliam · 2018-10-17T06:41:51Z

@katbyte

The portal doesn't really provide an easy way to view an existing log profile. You can query it via az cli with az monitor log-profiles list.

I've combined the tests and pasted the test results below.

~/go/src/github.com/terraform-providers/terraform-provider-azurerm on log-profile*
TESTARGS="-run TestAccAzureRMMonitorLogProfile -count=1" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAzureRMMonitorLogProfile -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-azurerm       [no test files]
=== RUN   TestAccAzureRMMonitorLogProfile
=== RUN   TestAccAzureRMMonitorLogProfile/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/servicebus
=== RUN   TestAccAzureRMMonitorLogProfile/basic/complete
=== RUN   TestAccAzureRMMonitorLogProfile/basic/disappears
=== RUN   TestAccAzureRMMonitorLogProfile/datasource
=== RUN   TestAccAzureRMMonitorLogProfile/datasource/eventhub
=== RUN   TestAccAzureRMMonitorLogProfile/datasource/storageaccount
--- PASS: TestAccAzureRMMonitorLogProfile (1070.07s)
    --- PASS: TestAccAzureRMMonitorLogProfile/basic (807.06s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/basic (98.02s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/servicebus (442.57s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/complete (174.21s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/disappears (92.27s)
    --- PASS: TestAccAzureRMMonitorLogProfile/datasource (263.01s)
        --- PASS: TestAccAzureRMMonitorLogProfile/datasource/eventhub (165.44s)
        --- PASS: TestAccAzureRMMonitorLogProfile/datasource/storageaccount (97.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       1070.106s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/authentication        0.023s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure 0.029s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/kubernetes    0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response      0.037s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/set   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/suppress      0.032s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate      0.026s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils 0.038s [no tests to run]
?       github.com/terraform-providers/terraform-provider-azurerm/version       [no test files]

katbyte

Thanks for the tip @liemnotliam! I was able to see there was one kicking around and delete it. Totally didn't think to use the cli.

I was able to get the tests to pass except the complete one, that then succeeded when i ran it after. Seems our subscription doesn't like provisioning and deprovisioning things so rapidly

gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMMonitorLogProfile -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMMonitorLogProfile
=== RUN   TestAccAzureRMMonitorLogProfile/datasource
=== RUN   TestAccAzureRMMonitorLogProfile/datasource/eventhub
=== RUN   TestAccAzureRMMonitorLogProfile/datasource/storageaccount
=== RUN   TestAccAzureRMMonitorLogProfile/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/servicebus
=== RUN   TestAccAzureRMMonitorLogProfile/basic/complete
=== RUN   TestAccAzureRMMonitorLogProfile/basic/disappears
--- FAIL: TestAccAzureRMMonitorLogProfile (1061.77s)
    --- PASS: TestAccAzureRMMonitorLogProfile/datasource (283.16s)
        --- PASS: TestAccAzureRMMonitorLogProfile/datasource/eventhub (182.56s)
        --- PASS: TestAccAzureRMMonitorLogProfile/datasource/storageaccount (100.60s)
    --- FAIL: TestAccAzureRMMonitorLogProfile/basic (778.61s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/basic (95.31s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/servicebus (449.11s)
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/complete (153.35s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:

        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:

        		* azurerm_monitor_log_profile.test: Error retrieving Log Profile "acctestlp-6353106286116217609": insights.LogProfilesClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="ResourceNotFound" Message="Log profile 'acctestlp-6353106286116217609' under scope '/subscriptions/c0a607b2-6372-4ef3-abdb-dbe52a7b56ba' doesn't exist."
        --- FAIL: TestAccAzureRMMonitorLogProfile/basic/disappears (80.85s)
        	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:

        		* azurerm_monitor_log_profile.test: 1 error(s) occurred:

        		* azurerm_monitor_log_profile.test: Error Creating/Updating Log Profile "acctestlp-4445915028616985967": insights.LogProfilesClient#CreateOrUpdate: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
FAIL
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1061.805s
make: *** [testacc] Error 1
[12:42:44] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm$ make fmt; make testacc TEST=./azurerm TESTARGS=-test.run=TestAccAzureRMMonitorLogProfile/basic/complete
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMMonitorLogProfile/basic/complete -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMMonitorLogProfile
=== RUN   TestAccAzureRMMonitorLogProfile/basic
=== RUN   TestAccAzureRMMonitorLogProfile/basic/complete
--- PASS: TestAccAzureRMMonitorLogProfile (163.17s)
    --- PASS: TestAccAzureRMMonitorLogProfile/basic (163.17s)
        --- PASS: TestAccAzureRMMonitorLogProfile/basic/complete (163.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	163.203s

So i'm going to say this LGTM now and merge 🙂

ghost · 2019-03-06T14:07:54Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

liemnotliam added 3 commits August 19, 2018 14:18

Add log profile resource

93225ee

* Update config and provider. * Add data and resource schemas. * Add docs. * Add acceptance tests.

Update log profile read

cc059f7

* Normalise locations. * Set storage account and service bus IDs directly.

Fix unsused variables

003fd2f

tombuildsstuff added new-resource service/monitor labels Aug 21, 2018

gpjonesii approved these changes Aug 21, 2018

View reviewed changes

metacpp requested a review from JunyiYi August 21, 2018 19:26

JunyiYi reviewed Aug 22, 2018

View reviewed changes

Add non-nil validation on name

1f416d3

ghost added the size/XXL label Aug 22, 2018

JunyiYi suggested changes Aug 23, 2018

View reviewed changes

JunyiYi added the waiting-response label Aug 23, 2018

JunyiYi self-assigned this Aug 23, 2018

liemnotliam added 4 commits August 23, 2018 08:32

Update log profile tests

52cf122

* Move import test to normal test case. * Update resource names.

Update log profile resource and data source

4d885b0

* Make retention policy days optional, which defaults to 0. * Add nil checks. * Add flatten locations function. * Refactor based on conventions.

Update log profile docs

a1c061b

Update log profile acc tests to run as combined tests

41d16a1

ghost added the size/XXL label Aug 24, 2018

metacpp added this to the Future milestone Aug 24, 2018

JunyiYi reviewed Aug 28, 2018

View reviewed changes

JunyiYi approved these changes Aug 31, 2018

View reviewed changes

tombuildsstuff removed the waiting-response label Sep 5, 2018

tombuildsstuff self-assigned this Sep 5, 2018

tombuildsstuff modified the milestones: Future, Soon Sep 26, 2018

tombuildsstuff requested changes Sep 26, 2018

View reviewed changes

tombuildsstuff unassigned JunyiYi Sep 26, 2018

tombuildsstuff added the waiting-response label Sep 26, 2018

liemnotliam added 7 commits October 3, 2018 10:37

Add monitor log profile sweeper

72dbe16

Merge branch 'master' into log-profile

f1c184b

Fix sidebar link text

bb575e1

Return more detailed error

1e9b6d0

Merge branch 'master' into log-profile

fc52aa2

Rename log profiles client to include monitor prefix

abe39d7

tombuildsstuff removed the waiting-response label Oct 13, 2018

Merge master into log-profile

8f7b279

katbyte force-pushed the log-profile branch from 2b8d233 to 8f7b279 Compare October 15, 2018 19:29

katbyte requested changes Oct 15, 2018

View reviewed changes

liemnotliam added 2 commits October 16, 2018 08:44

Merge branch 'master' into log-profile

006ec9d

Update log profile docs wording and format test templates

faabaa8

Combine log profile tests to prevent conflicts

3812cc5

Added comments and doubled creation timeout

cb5471a

katbyte approved these changes Oct 18, 2018

View reviewed changes

katbyte merged commit 1aef180 into hashicorp:master Oct 18, 2018

katbyte added a commit that referenced this pull request Oct 18, 2018

Update CHANGELOG.md to include #1792

682b57c

katbyte modified the milestones: Soon, 1.17.0 Oct 18, 2018

tombuildsstuff mentioned this pull request Oct 24, 2018

Feature Request: Azure Monitor Log Profiles #1175

Closed

liemnotliam deleted the log-profile branch October 29, 2018 14:22

ghost locked and limited conversation to collaborators Mar 6, 2019


		* `categories` - List of categories of the logs.

		* `retention_policy`- A retention policy for how long Activity Logs are retained in the storage account.


		# azurerm_monitor_log_profile

		Creates a [Log Profile](https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/monitoring-overview-activity-logs#export-the-activity-log-with-a-log-profile). A Log Profile configures how Activity Logs are exported.

New Resource: azurerm_log_profile #1792

New Resource: azurerm_log_profile #1792

Conversation

liemnotliam commented Aug 19, 2018

JunyiYi left a comment

Choose a reason for hiding this comment

JunyiYi Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi left a comment • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

JunyiYi left a comment

Choose a reason for hiding this comment

liemnotliam commented Aug 28, 2018

JunyiYi left a comment

Choose a reason for hiding this comment

liemnotliam commented Sep 4, 2018

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liemnotliam commented Oct 12, 2018

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liemnotliam commented Oct 16, 2018

katbyte commented Oct 16, 2018

katbyte commented Oct 16, 2018

liemnotliam commented Oct 17, 2018 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Mar 6, 2019

JunyiYi Aug 22, 2018 •

edited

Loading

JunyiYi Aug 22, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi left a comment •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

JunyiYi Aug 23, 2018 •

edited

Loading

liemnotliam commented Oct 17, 2018 •

edited

Loading