Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_dev_test_policy #2070

Merged
merged 2 commits into from
Oct 12, 2018
Merged

New Resource: azurerm_dev_test_policy #2070

merged 2 commits into from
Oct 12, 2018

Conversation

tombuildsstuff
Copy link
Member

Tests pass:

$ acctests azurerm TestAccAzureRMDevTestPolicy_
=== RUN   TestAccAzureRMDevTestPolicy_basic

--- PASS: TestAccAzureRMDevTestPolicy_basic (610.83s)
=== RUN   TestAccAzureRMDevTestPolicy_complete
--- PASS: TestAccAzureRMDevTestPolicy_complete (367.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	979.183s

@tombuildsstuff tombuildsstuff added this to the 1.17.0 milestone Oct 12, 2018
@ghost ghost added the size/XL label Oct 12, 2018
@tombuildsstuff tombuildsstuff requested a review from a team October 12, 2018 21:31
katbyte
katbyte approved these changes Oct 12, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one comment question LGTM @tombuildsstuff 👍

azurerm/resource_arm_dev_test_policy_test.go Show resolved Hide resolved
@tombuildsstuff
Copy link
Member Author

Tests pass:

screenshot 2018-10-12 at 12 38 39

@tombuildsstuff tombuildsstuff merged commit cb09837 into master Oct 12, 2018
@tombuildsstuff tombuildsstuff deleted the f/dtl-policy branch October 12, 2018 22:40
tombuildsstuff added a commit that referenced this pull request Oct 12, 2018
@tombuildsstuff
Updating to include #2070
44441c8
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-resource service/devtestlabs size/XL
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tombuildsstuff @katbyte